Re: [PATCH] s390: disable -Warray-bounds

David Howells
2022-06-09T14:14:57Z

Linus Torvalds <torvalds@linux-foundation.org> wrote:

> > Yeah. Happily, this has already been solved, but it looks like David didn't do a pull yet for it?
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache-next
>
> Good.

Do you want it tagging and a pull req generating, even though it's a single
patch?

Note that Dave Chinner would rather I converted code like:

struct myfs_inode *myfsinode = xyz;
myfsinode->netfs.inode.i_ino = 123;

to something like:

struct myfs_inode *myfsinode = xyz;
struct inode *inode = VFS_I(myfsinode);
inode->i_ino = 123;

where the translation is wrapped inside a VFS_I() macro in every filesystem
and wants this across all filesystems. I think the former looks cleaner, but
he has a point about how to deal with yet another layer of wrapping being
inserted in the future. Do you have a preference?

David