From: Anup Patel <apatel@ventanamicro.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Atish Patra <atishp@atishpatra.org>,
Alistair Francis <Alistair.Francis@wdc.com>,
Anup Patel <anup@brainfault.org>,
linux-remoteproc@vger.kernel.org, kvm-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org,
Anup Patel <apatel@ventanamicro.com>
Subject: [PATCH] rpmsg: virtio: Fix broken rpmsg_probe()
Date: Wed, 8 Jun 2022 22:43:34 +0530 [thread overview]
Message-ID: <20220608171334.730739-1-apatel@ventanamicro.com> (raw)
The rpmsg_probe() is broken at the moment because virtqueue_add_inbuf()
fails due to both virtqueues (Rx and Tx) marked as broken by the
__vring_new_virtqueue() function. To solve this, virtio_device_ready()
(which unbreaks queues) should be called before virtqueue_add_inbuf().
Fixes: 8b4ec69d7e09 ("virtio: harden vring IRQ")
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
drivers/rpmsg/virtio_rpmsg_bus.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
index 905ac7910c98..71a64d2c7644 100644
--- a/drivers/rpmsg/virtio_rpmsg_bus.c
+++ b/drivers/rpmsg/virtio_rpmsg_bus.c
@@ -929,6 +929,9 @@ static int rpmsg_probe(struct virtio_device *vdev)
/* and half is dedicated for TX */
vrp->sbufs = bufs_va + total_buf_space / 2;
+ /* From this point on, we can notify and get callbacks. */
+ virtio_device_ready(vdev);
+
/* set up the receive buffers */
for (i = 0; i < vrp->num_bufs / 2; i++) {
struct scatterlist sg;
@@ -983,9 +986,6 @@ static int rpmsg_probe(struct virtio_device *vdev)
*/
notify = virtqueue_kick_prepare(vrp->rvq);
- /* From this point on, we can notify and get callbacks. */
- virtio_device_ready(vdev);
-
/* tell the remote processor it can start sending messages */
/*
* this might be concurrent with callbacks, but we are only
--
2.34.1
next reply other threads:[~2022-06-08 17:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 17:13 Anup Patel [this message]
2022-06-29 17:43 ` [PATCH] rpmsg: virtio: Fix broken rpmsg_probe() Mathieu Poirier
2022-06-30 7:31 ` Anup Patel
2022-06-30 16:20 ` Arnaud POULIQUEN
2022-06-30 17:51 ` Mathieu Poirier
2022-06-30 19:20 ` Michael S. Tsirkin
2022-07-01 1:22 ` Jason Wang
2022-07-01 6:16 ` Michael S. Tsirkin
2022-07-04 4:35 ` Jason Wang
2022-07-04 9:44 ` Arnaud POULIQUEN
2022-07-06 4:03 ` Jason Wang
2022-07-06 6:56 ` Arnaud POULIQUEN
2022-07-08 6:19 ` Jason Wang
2022-07-08 8:00 ` Arnaud POULIQUEN
2022-07-12 8:21 ` Jason Wang
2022-06-30 19:19 ` Michael S. Tsirkin
2022-07-01 9:00 ` Arnaud POULIQUEN
2022-07-01 9:39 ` Michael S. Tsirkin
2022-06-30 19:16 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608171334.730739-1-apatel@ventanamicro.com \
--to=apatel@ventanamicro.com \
--cc=Alistair.Francis@wdc.com \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=bjorn.andersson@linaro.org \
--cc=kvm-riscv@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox