Re: [PATCH v2 3/5] dt-bindings: input: Use common 'linux,keycodes' definition

Jeff LaBundy
2022-06-09T01:34:45Z

Hi Rob,

On Wed, Jun 08, 2022 at 03:12:05PM -0600, Rob Herring wrote:
> The common input schema, input.yaml, already defines 'linux,keycodes'
> property. Update the users to use it.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Jeff LaBundy <jeff@labundy.com>

> ---
> Documentation/devicetree/bindings/input/iqs626a.yaml | 2 +-
> Documentation/devicetree/bindings/input/iqs62x-keys.yaml | 4 +++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/iqs626a.yaml b/Documentation/devicetree/bindings/input/iqs626a.yaml
> index e645521da8ba..008959f2d425 100644
> --- a/Documentation/devicetree/bindings/input/iqs626a.yaml
> +++ b/Documentation/devicetree/bindings/input/iqs626a.yaml
> @@ -510,6 +510,7 @@ patternProperties:
>
> "^trackpad-3x[2-3]$":
> type: object
> + $ref: input.yaml#
> description:
> Represents all channels associated with the trackpad. The channels are
> collectively active if the trackpad is defined and inactive otherwise.
> @@ -678,7 +679,6 @@ patternProperties:
> Specifies the raw count filter strength during low-power mode.
>
> linux,keycodes:
> - $ref: /schemas/types.yaml#/definitions/uint32-array
> minItems: 1
> maxItems: 6
> description: |
> diff --git a/Documentation/devicetree/bindings/input/iqs62x-keys.yaml b/Documentation/devicetree/bindings/input/iqs62x-keys.yaml
> index e677e31fe8fe..0aa951f0ab92 100644
> --- a/Documentation/devicetree/bindings/input/iqs62x-keys.yaml
> +++ b/Documentation/devicetree/bindings/input/iqs62x-keys.yaml
> @@ -9,6 +9,9 @@ title: Azoteq IQS620A/621/622/624/625 Keys and Switches
> maintainers:
> - Jeff LaBundy <jeff@labundy.com>
>
> +allOf:
> + - $ref: input.yaml#
> +
> description: |
> The Azoteq IQS620A, IQS621, IQS622, IQS624 and IQS625 multi-function sensors
> feature a variety of self-capacitive, mutual-inductive and Hall-effect sens-
> @@ -30,7 +33,6 @@ properties:
> - azoteq,iqs625-keys
>
> linux,keycodes:
> - $ref: /schemas/types.yaml#/definitions/uint32-array
> minItems: 1
> maxItems: 16
> description: |
> --
> 2.34.1
>

Kind regards,
Jeff LaBundy