Re: [PATCH RESEND] Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files

[Juerg Haefliger <juergh@proton.me>]

[-- Attachment #1: Type: text/plain, Size: 1540 bytes --]

On Thu, 05 May 2022 06:07:52 +0000
"Juerg Haefliger" <juergh@protonmail.com> wrote:

> Hi Marcel,
>
>
> > Hi Juerg,
> >
> > > The ath3k driver loads patch and configuration files so add MODULE_FIRMWARE
> > > macros to povide that information via modinfo.
> > >
> > > Signed-off-by: Juerg Haefliger <juergh@protonmail.com>
> > > ---
> > > RESEND:
> > >  Resend from protonmail email account to please the test bot.
> > > ---
> > > drivers/bluetooth/ath3k.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> > > index 88262d3a9392..56e9a64177ae 100644
> > > --- a/drivers/bluetooth/ath3k.c
> > > +++ b/drivers/bluetooth/ath3k.c
> > > @@ -538,3 +538,5 @@ MODULE_DESCRIPTION("Atheros AR30xx firmware driver");
> > > MODULE_VERSION(VERSION);
> > > MODULE_LICENSE("GPL");
> > > MODULE_FIRMWARE(ATH3K_FIRMWARE);
> > > +MODULE_FIRMWARE("ar3k/AthrBT_0x*.dfu");
> > > +MODULE_FIRMWARE("ar3k/ramps_0x*_*.dfu");
> >
> > I am still not convinced by the glob file matching. How would that actually work?
>
> In my case I need to remove firmware blobs that the kernel doesn't need to
> reduce disk usage. This information helps. While it might retain unneeded
> versions it's still better than nothing.

Ping. So what do you suggest? Hard-code all filenames based on what's
currently in linux-firmware? Given the HW is quite old that might not change
very often...

...Juerg

>
> ...Juerg
>
>
> > Regards
> >
> > Marcel
> >
>


[-- Attachment #2: attachment.sig --]
[-- Type: application/pgp-signature, Size: 849 bytes --]