Re: [PATCH v2 01/48] dt-bindings: input: gpio-keys: enforce node names to match all properties

Rob Herring
2022-06-09T15:17:45Z

On Thu, 09 Jun 2022 13:38:43 +0200, Krzysztof Kozlowski wrote:
> The gpio-keys DT schema matches all properties with a wide pattern and
> applies specific schema to children. This has drawback - all regular
> properties are also matched and are silently ignored, even if they are
> not described in schema. Basically this allows any non-object property
> to be present.
>
> Enforce specific naming pattern for children (keys) to narrow the
> pattern thus do not match other properties. This will require all
> children to be named with 'key-' prefix or '-key' suffix.
>
> Removal of "if:" within patternProperties causes drop of one indentation
> level, but there are no other changes in the affected block.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/input/gpio-keys.yaml | 157 +++++++++---------
> 1 file changed, 77 insertions(+), 80 deletions(-)
>

Reviewed-by: Rob Herring <robh@kernel.org>