From: Rob Herring <robh@kernel.org>
To: Yoan Picchi <yoan.picchi@arm.com>
Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
qat-linux@intel.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andre Przywara <andre.przywara@arm.com>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH 2/2] Removes the x86 dependency on the QAT drivers
Date: Thu, 9 Jun 2022 15:36:52 -0600 [thread overview]
Message-ID: <20220609213652.GA115440-robh@kernel.org> (raw)
In-Reply-To: <20220607165840.66931-3-yoan.picchi@arm.com>
On Tue, Jun 07, 2022 at 04:58:40PM +0000, Yoan Picchi wrote:
> This dependency looks outdated. After the previous patch, we have been able
> to use this driver to encrypt some data and to create working VF on arm64.
> We have not tested it yet on any big endian machine, hence the new dependency
For the subject, use prefixes matching the subsystem (like you did on
patch 1).
The only testing obligation you have is compiling for BE. If kconfig was
supposed to capture what endianness drivers have been tested or not
tested with, then lots of drivers are missing the dependency. Kconfig
depends/select entries should generally be either to prevent compile
failures (you checked PPC, RiscV, etc.?) or to hide drivers *really*
specific to a platform. IMO, we should only have !CPU_BIG_ENDIAN if it
is known not to work and not easily fixed.
Also, with the dependency, no one can test the driver without modifying
the kernel and if it does work as-is, then one has to upstream a change
and then wait for it to show up in distro kernels. You could mitigate
the first part with COMPILE_TEST.
Rob
next prev parent reply other threads:[~2022-06-09 21:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 16:58 [PATCH 0/2] Crypto: Remove x86 dependency on QAT drivers Yoan Picchi
2022-06-07 16:58 ` [PATCH 1/2] crypto: qat: replace get_current_node() with numa_node_id() Yoan Picchi
2022-06-07 16:58 ` [PATCH 2/2] Removes the x86 dependency on the QAT drivers Yoan Picchi
2022-06-09 21:36 ` Rob Herring [this message]
2022-06-10 10:48 ` Andre Przywara
2022-06-13 10:41 ` Giovanni Cabiddu
2022-06-13 13:44 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2022-06-13 14:25 [PATCH 0/2] Crypto: Remove x86 dependency on " Yoan Picchi
2022-06-13 14:25 ` [PATCH 2/2] Removes the x86 dependency on the " Yoan Picchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220609213652.GA115440-robh@kernel.org \
--to=robh@kernel.org \
--cc=andre.przywara@arm.com \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=yoan.picchi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).