From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD26FC43334 for ; Fri, 10 Jun 2022 06:02:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346379AbiFJGCE (ORCPT ); Fri, 10 Jun 2022 02:02:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243100AbiFJGCA (ORCPT ); Fri, 10 Jun 2022 02:02:00 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE63E1312A8 for ; Thu, 9 Jun 2022 23:01:59 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 1216768AA6; Fri, 10 Jun 2022 08:01:56 +0200 (CEST) Date: Fri, 10 Jun 2022 08:01:54 +0200 From: Christoph Hellwig To: Robin Murphy Cc: will@kernel.org, joro@8bytes.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, hch@lst.de, john.garry@huawei.com Subject: Re: [PATCH v2] iommu/dma: Add config for PCI SAC address trick Message-ID: <20220610060154.GC24331@lst.de> References: <3f06994f9f370f9d35b2630ab75171ecd2065621.1654782107.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f06994f9f370f9d35b2630ab75171ecd2065621.1654782107.git.robin.murphy@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, 2022 at 04:12:10PM +0100, Robin Murphy wrote: > + If you have a modern PCI Express based system, this feature mostly just Overly long line here. Otherwise looks good: Reviewed-by: Christoph Hellwig