From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Genjian Zhang <zhanggenjian123@gmail.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, f.fainelli@gmail.com,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, huhai@kylinos.cn,
k2ci <kernel-bot@kylinos.cn>
Subject: Re: [PATCH v3] MIPS: Remove repetitive increase irq_err_count
Date: Fri, 10 Jun 2022 10:30:44 +0200 [thread overview]
Message-ID: <20220610083044.GA7565@alpha.franken.de> (raw)
In-Reply-To: <20220525043916.584850-1-zhanggenjian@kylinos.cn>
On Wed, May 25, 2022 at 12:39:16PM +0800, Genjian Zhang wrote:
> From: huhai <huhai@kylinos.cn>
>
> commit 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx") added
> a function irq_dispatch, and it'll increase irq_err_count when the get_irq
> callback returns a negative value, but increase irq_err_count in get_irq
> was not removed.
>
> And also, modpost complains once gpio-vr41xx drivers become modules.
> ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined!
>
> So it would be a good idea to remove repetitive increase irq_err_count in
> get_irq callback.
>
> Fixes: 27fdd325dace ("MIPS: Update VR41xx GPIO driver to use gpiolib")
> Fixes: 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx")
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: huhai <huhai@kylinos.cn>
This is missing your the Signed-off-by as submitter of the patch.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2022-06-10 8:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 4:39 [PATCH v3] MIPS: Remove repetitive increase irq_err_count Genjian Zhang
2022-06-10 8:30 ` Thomas Bogendoerfer [this message]
2022-06-10 11:14 ` [PATCH v4] " Genjian Zhang
2022-06-21 15:14 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220610083044.GA7565@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=brgl@bgdev.pl \
--cc=f.fainelli@gmail.com \
--cc=huhai@kylinos.cn \
--cc=kernel-bot@kylinos.cn \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=zhanggenjian123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox