* [PATCH v3] MIPS: Remove repetitive increase irq_err_count
@ 2022-05-25 4:39 Genjian Zhang
2022-06-10 8:30 ` Thomas Bogendoerfer
2022-06-10 11:14 ` [PATCH v4] " Genjian Zhang
0 siblings, 2 replies; 4+ messages in thread
From: Genjian Zhang @ 2022-05-25 4:39 UTC (permalink / raw)
To: tsbogend, linus.walleij, brgl, f.fainelli
Cc: linux-mips, linux-kernel, linux-gpio, huhai, zhanggenjian123,
k2ci
From: huhai <huhai@kylinos.cn>
commit 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx") added
a function irq_dispatch, and it'll increase irq_err_count when the get_irq
callback returns a negative value, but increase irq_err_count in get_irq
was not removed.
And also, modpost complains once gpio-vr41xx drivers become modules.
ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined!
So it would be a good idea to remove repetitive increase irq_err_count in
get_irq callback.
Fixes: 27fdd325dace ("MIPS: Update VR41xx GPIO driver to use gpiolib")
Fixes: 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx")
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: huhai <huhai@kylinos.cn>
---
arch/mips/vr41xx/common/icu.c | 2 --
drivers/gpio/gpio-vr41xx.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/arch/mips/vr41xx/common/icu.c b/arch/mips/vr41xx/common/icu.c
index 7b7f25b4b057..9240bcdbe74e 100644
--- a/arch/mips/vr41xx/common/icu.c
+++ b/arch/mips/vr41xx/common/icu.c
@@ -640,8 +640,6 @@ static int icu_get_irq(unsigned int irq)
printk(KERN_ERR "spurious ICU interrupt: %04x,%04x\n", pend1, pend2);
- atomic_inc(&irq_err_count);
-
return -1;
}
diff --git a/drivers/gpio/gpio-vr41xx.c b/drivers/gpio/gpio-vr41xx.c
index 98cd715ccc33..8d09b619c166 100644
--- a/drivers/gpio/gpio-vr41xx.c
+++ b/drivers/gpio/gpio-vr41xx.c
@@ -217,8 +217,6 @@ static int giu_get_irq(unsigned int irq)
printk(KERN_ERR "spurious GIU interrupt: %04x(%04x),%04x(%04x)\n",
maskl, pendl, maskh, pendh);
- atomic_inc(&irq_err_count);
-
return -EINVAL;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] MIPS: Remove repetitive increase irq_err_count
2022-05-25 4:39 [PATCH v3] MIPS: Remove repetitive increase irq_err_count Genjian Zhang
@ 2022-06-10 8:30 ` Thomas Bogendoerfer
2022-06-10 11:14 ` [PATCH v4] " Genjian Zhang
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2022-06-10 8:30 UTC (permalink / raw)
To: Genjian Zhang
Cc: linus.walleij, brgl, f.fainelli, linux-mips, linux-kernel,
linux-gpio, huhai, k2ci
On Wed, May 25, 2022 at 12:39:16PM +0800, Genjian Zhang wrote:
> From: huhai <huhai@kylinos.cn>
>
> commit 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx") added
> a function irq_dispatch, and it'll increase irq_err_count when the get_irq
> callback returns a negative value, but increase irq_err_count in get_irq
> was not removed.
>
> And also, modpost complains once gpio-vr41xx drivers become modules.
> ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined!
>
> So it would be a good idea to remove repetitive increase irq_err_count in
> get_irq callback.
>
> Fixes: 27fdd325dace ("MIPS: Update VR41xx GPIO driver to use gpiolib")
> Fixes: 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx")
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: huhai <huhai@kylinos.cn>
This is missing your the Signed-off-by as submitter of the patch.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v4] MIPS: Remove repetitive increase irq_err_count
2022-05-25 4:39 [PATCH v3] MIPS: Remove repetitive increase irq_err_count Genjian Zhang
2022-06-10 8:30 ` Thomas Bogendoerfer
@ 2022-06-10 11:14 ` Genjian Zhang
2022-06-21 15:14 ` Thomas Bogendoerfer
1 sibling, 1 reply; 4+ messages in thread
From: Genjian Zhang @ 2022-06-10 11:14 UTC (permalink / raw)
To: tsbogend, linus.walleij, brgl, f.fainelli
Cc: linux-mips, linux-kernel, linux-gpio, huhai, k2ci, Genjian Zhang
From: huhai <huhai@kylinos.cn>
commit 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx") added
a function irq_dispatch, and it'll increase irq_err_count when the get_irq
callback returns a negative value, but increase irq_err_count in get_irq
was not removed.
And also, modpost complains once gpio-vr41xx drivers become modules.
ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined!
So it would be a good idea to remove repetitive increase irq_err_count in
get_irq callback.
Fixes: 27fdd325dace ("MIPS: Update VR41xx GPIO driver to use gpiolib")
Fixes: 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx")
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: huhai <huhai@kylinos.cn>
Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
---
arch/mips/vr41xx/common/icu.c | 2 --
drivers/gpio/gpio-vr41xx.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/arch/mips/vr41xx/common/icu.c b/arch/mips/vr41xx/common/icu.c
index 7b7f25b4b057..9240bcdbe74e 100644
--- a/arch/mips/vr41xx/common/icu.c
+++ b/arch/mips/vr41xx/common/icu.c
@@ -640,8 +640,6 @@ static int icu_get_irq(unsigned int irq)
printk(KERN_ERR "spurious ICU interrupt: %04x,%04x\n", pend1, pend2);
- atomic_inc(&irq_err_count);
-
return -1;
}
diff --git a/drivers/gpio/gpio-vr41xx.c b/drivers/gpio/gpio-vr41xx.c
index 98cd715ccc33..8d09b619c166 100644
--- a/drivers/gpio/gpio-vr41xx.c
+++ b/drivers/gpio/gpio-vr41xx.c
@@ -217,8 +217,6 @@ static int giu_get_irq(unsigned int irq)
printk(KERN_ERR "spurious GIU interrupt: %04x(%04x),%04x(%04x)\n",
maskl, pendl, maskh, pendh);
- atomic_inc(&irq_err_count);
-
return -EINVAL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4] MIPS: Remove repetitive increase irq_err_count
2022-06-10 11:14 ` [PATCH v4] " Genjian Zhang
@ 2022-06-21 15:14 ` Thomas Bogendoerfer
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2022-06-21 15:14 UTC (permalink / raw)
To: Genjian Zhang
Cc: linus.walleij, brgl, f.fainelli, linux-mips, linux-kernel,
linux-gpio, huhai, k2ci, Genjian Zhang
On Fri, Jun 10, 2022 at 07:14:20PM +0800, Genjian Zhang wrote:
> From: huhai <huhai@kylinos.cn>
>
> commit 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx") added
> a function irq_dispatch, and it'll increase irq_err_count when the get_irq
> callback returns a negative value, but increase irq_err_count in get_irq
> was not removed.
>
> And also, modpost complains once gpio-vr41xx drivers become modules.
> ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined!
>
> So it would be a good idea to remove repetitive increase irq_err_count in
> get_irq callback.
>
> Fixes: 27fdd325dace ("MIPS: Update VR41xx GPIO driver to use gpiolib")
> Fixes: 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx")
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: huhai <huhai@kylinos.cn>
> Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
> ---
> arch/mips/vr41xx/common/icu.c | 2 --
> drivers/gpio/gpio-vr41xx.c | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/arch/mips/vr41xx/common/icu.c b/arch/mips/vr41xx/common/icu.c
> index 7b7f25b4b057..9240bcdbe74e 100644
> --- a/arch/mips/vr41xx/common/icu.c
> +++ b/arch/mips/vr41xx/common/icu.c
> @@ -640,8 +640,6 @@ static int icu_get_irq(unsigned int irq)
>
> printk(KERN_ERR "spurious ICU interrupt: %04x,%04x\n", pend1, pend2);
>
> - atomic_inc(&irq_err_count);
> -
> return -1;
> }
>
> diff --git a/drivers/gpio/gpio-vr41xx.c b/drivers/gpio/gpio-vr41xx.c
> index 98cd715ccc33..8d09b619c166 100644
> --- a/drivers/gpio/gpio-vr41xx.c
> +++ b/drivers/gpio/gpio-vr41xx.c
> @@ -217,8 +217,6 @@ static int giu_get_irq(unsigned int irq)
> printk(KERN_ERR "spurious GIU interrupt: %04x(%04x),%04x(%04x)\n",
> maskl, pendl, maskh, pendh);
>
> - atomic_inc(&irq_err_count);
> -
> return -EINVAL;
> }
>
> --
> 2.25.1
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-21 15:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-25 4:39 [PATCH v3] MIPS: Remove repetitive increase irq_err_count Genjian Zhang
2022-06-10 8:30 ` Thomas Bogendoerfer
2022-06-10 11:14 ` [PATCH v4] " Genjian Zhang
2022-06-21 15:14 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox