* [PATCH v1 1/1] hwmon: (nct6775) Drop duplicate NULL check in ->init() and ->exit()
@ 2022-06-10 10:33 Andy Shevchenko
2022-06-10 17:58 ` Zev Weiss
2022-06-11 14:06 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2022-06-10 10:33 UTC (permalink / raw)
To: Zev Weiss, Andy Shevchenko, linux-hwmon, linux-kernel
Cc: Guenter Roeck, Jean Delvare
Since platform_device_unregister() is NULL-aware, we don't need to duplicate
this check. Remove it and fold the rest of the code.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/hwmon/nct6775-platform.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/hwmon/nct6775-platform.c b/drivers/hwmon/nct6775-platform.c
index 6d46c9401898..3a48627419ba 100644
--- a/drivers/hwmon/nct6775-platform.c
+++ b/drivers/hwmon/nct6775-platform.c
@@ -1200,10 +1200,8 @@ static int __init sensors_nct6775_platform_init(void)
exit_device_put:
platform_device_put(pdev[i]);
exit_device_unregister:
- while (--i >= 0) {
- if (pdev[i])
- platform_device_unregister(pdev[i]);
- }
+ while (i--)
+ platform_device_unregister(pdev[i]);
exit_unregister:
platform_driver_unregister(&nct6775_driver);
return err;
@@ -1213,10 +1211,8 @@ static void __exit sensors_nct6775_platform_exit(void)
{
int i;
- for (i = 0; i < ARRAY_SIZE(pdev); i++) {
- if (pdev[i])
- platform_device_unregister(pdev[i]);
- }
+ for (i = 0; i < ARRAY_SIZE(pdev); i++)
+ platform_device_unregister(pdev[i]);
platform_driver_unregister(&nct6775_driver);
}
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] hwmon: (nct6775) Drop duplicate NULL check in ->init() and ->exit()
2022-06-10 10:33 [PATCH v1 1/1] hwmon: (nct6775) Drop duplicate NULL check in ->init() and ->exit() Andy Shevchenko
@ 2022-06-10 17:58 ` Zev Weiss
2022-06-11 14:06 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Zev Weiss @ 2022-06-10 17:58 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-hwmon, linux-kernel, Guenter Roeck, Jean Delvare
On Fri, Jun 10, 2022 at 03:33:24AM PDT, Andy Shevchenko wrote:
>Since platform_device_unregister() is NULL-aware, we don't need to duplicate
>this check. Remove it and fold the rest of the code.
>
>Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>---
> drivers/hwmon/nct6775-platform.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
Reviewed-by: Zev Weiss <zev@bewilderbeest.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] hwmon: (nct6775) Drop duplicate NULL check in ->init() and ->exit()
2022-06-10 10:33 [PATCH v1 1/1] hwmon: (nct6775) Drop duplicate NULL check in ->init() and ->exit() Andy Shevchenko
2022-06-10 17:58 ` Zev Weiss
@ 2022-06-11 14:06 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2022-06-11 14:06 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Zev Weiss, linux-hwmon, linux-kernel, Jean Delvare
On Fri, Jun 10, 2022 at 01:33:24PM +0300, Andy Shevchenko wrote:
> Since platform_device_unregister() is NULL-aware, we don't need to duplicate
> this check. Remove it and fold the rest of the code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Zev Weiss <zev@bewilderbeest.net>
Applied to hwmon-next.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-11 14:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-10 10:33 [PATCH v1 1/1] hwmon: (nct6775) Drop duplicate NULL check in ->init() and ->exit() Andy Shevchenko
2022-06-10 17:58 ` Zev Weiss
2022-06-11 14:06 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox