Re: [PATCH v6 03/13] mm/demotion: Return error on write to numa_demotion sysfs

Ying Huang
2022-06-13T03:27:16Z

On Fri, 2022-06-10 at 19:22 +0530, Aneesh Kumar K.V wrote:
> With CONFIG_MIGRATION disabled return EINVAL on write.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> ---
>  mm/memory-tiers.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index 9c6b40d7e0bf..c3123a457d90 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -105,6 +105,9 @@ static ssize_t numa_demotion_enabled_store(struct kobject *kobj,
>  {
>   ssize_t ret;
>
>
> + if (!IS_ENABLED(CONFIG_MIGRATION))
> + return -EINVAL;
> +

How about enclose numa_demotion_enabled_xxx related code with CONFIG_MIGRATION?

>   ret = kstrtobool(buf, &numa_demotion_enabled);
>   if (ret)
>   return ret;

Best Regards,
Huang, Ying