Re: [PATCH] Common clock: ​​To list active consumers of clocks

<Vishal Badole>
2022-08-21T17:59:26Z

On Sun, Aug 21, 2022 at 05:07:00AM +0000, Elliott, Robert (Servers) wrote:
>
>
> > -----Original Message-----
> > From: <Vishal Badole> <badolevishal1116@gmail.com>
> > Sent: Monday, August 8, 2022 12:00 PM
> > To: Elliott, Robert (Servers) <elliott@hpe.com>
> > Cc: Stephen Boyd <sboyd@kernel.org>; mturquette@baylibre.com; inux-
> > clk@vger.kernel.org; linux-kernel@vger.kernel.org; chinmoyghosh2001@gmail.com;
> > mintupatel89@gmail.com; vimal.kumar32@gmail.com
> > Subject: Re: [PATCH] Common clock: ​​To list active consumers of clocks
> >
> > On Tue, Aug 02, 2022 at 10:49:17PM +0000, Elliott, Robert (Servers) wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: <Vishal Badole> <badolevishal1116@gmail.com>
> > > > Sent: Sunday, June 26, 2022 1:25 PM
> > > > To: Stephen Boyd <sboyd@kernel.org>; mturquette@baylibre.com; inux-
> > > > clk@vger.kernel.org; linux-kernel@vger.kernel.org
> > > > Cc: chinmoyghosh2001@gmail.com; mintupatel89@gmail.com;
> > > > vimal.kumar32@gmail.com
> > > > Subject: Re: [PATCH] Common clock: ​​To list active consumers of clocks
> > > >
> > > ...
> > > > We will remove above prints in the revised patch. We are facing
> > > > indentation issue whle printing consumer in summary
> > > > as given below
> > > > enable prepare protect
> > duty hardware per-user
> > > > clock count count count
> > rateccuracy phase cycle enable consumer count
> > > > clk_mcasp0_fixed 0 0 0
> > 24576000 0 50000 Y
> > > > deviceless 0
> > >
> > > Consider making the kernel output simple, greppable, and parseable (e.g.,
> > > comma-separated fields, one entry per line, no multi-line column headers)
> > > and let a userspace tool do the fancy formatting.
> > >
> > Hi Robert,
> > We have raised another patch for the same. Please find the below link
> > for reference:
> >
> > https://www.spinics.net/lists/kernel/msg4459705.html
>
> That output is still not parsable.
>
> I suggest making the kernel output more like:
> clock,enable count,prepare count,protect count,rate,accuracy,phase,duty cycle,hardware enable,consumer,per-user count
> clk_mcasp0_fixed,0,0,0,24576000,0,0,50000,Y,deviceless,0
> clk_mcasp0,0,0,0,24576000,0,0,50000,N,simple-audio-card;cpu,0
>
> and make a userspace program like lsmod, lscpu, lsblk, lspci,
> or lsusb to print the data with fancy columns or apply
> other filters.
>
> That allows adding or removing column headers, assuming the
> userspace program doesn't hardcode assumptions about them.
>

Hi Robert,
As per the review given by stephen Boyd, who is one of maintainer of
clk.c, suggested to add consumer's name and per user count in clock
summary only. We are also getting proper formatted and parsable output
on our target board console but when we copy and paste the same in
commit message its format is getting changed. Please apply this patch
and check on your target.

Regards,
Vishal