* [PATCH] lib/cpu_rmap: do *_get before using cpu_rmap
@ 2022-06-11 8:09 wuchi
0 siblings, 0 replies; only message in thread
From: wuchi @ 2022-06-11 8:09 UTC (permalink / raw)
To: bhutchings, decot, info, josh; +Cc: akpm, linux-kernel
It's ok in irq_cpu_rmap_add:
glue->rmap = rmap;
cpu_rmap_get(rmap);
however, it's logically better to do *_get before passing the var..
Signed-off-by: wuchi <wuchi.zero@gmail.com>
---
lib/cpu_rmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/cpu_rmap.c b/lib/cpu_rmap.c
index f08d9c56f712..590eb544f0d8 100644
--- a/lib/cpu_rmap.c
+++ b/lib/cpu_rmap.c
@@ -291,8 +291,8 @@ int irq_cpu_rmap_add(struct cpu_rmap *rmap, int irq)
return -ENOMEM;
glue->notify.notify = irq_cpu_rmap_notify;
glue->notify.release = irq_cpu_rmap_release;
- glue->rmap = rmap;
cpu_rmap_get(rmap);
+ glue->rmap = rmap;
glue->index = cpu_rmap_add(rmap, glue);
rc = irq_set_affinity_notifier(irq, &glue->notify);
if (rc) {
--
2.20.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-11 8:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-11 8:09 [PATCH] lib/cpu_rmap: do *_get before using cpu_rmap wuchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox