From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D058C43334 for ; Sat, 11 Jun 2022 09:31:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232456AbiFKJbO (ORCPT ); Sat, 11 Jun 2022 05:31:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbiFKJbM (ORCPT ); Sat, 11 Jun 2022 05:31:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2596326D0; Sat, 11 Jun 2022 02:31:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 38F8B60B15; Sat, 11 Jun 2022 09:31:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D251BC34116; Sat, 11 Jun 2022 09:31:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654939870; bh=JEHB2+yb07hk08YAU9SCnhBZyTJpoJajIXfHmENt1Z0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W2/NspDpexJKGkKbkeNkX+chUN9NG/XpSSb54CsMxzviqb+n4LdMJi0V3YoW/8cbE OZdUPecVv2z2pqAhccX5dBjSqwHE3++fUnbxNzA4F6//JvZ5qwiVYmV2UGt/k0KMpx REKJeRtRRIeH+CKClrIq0AuFF06/IG4XXyw8RNPS5FKnSfGowBKTT7kKWtci+zNqcd GNNvYpEuKKmH5MsCwbLFJ5ohPKW2YBLMSWO94m4pUpRUAzXtfghP2JMGh9WlPAt3C3 0oA7GSO7sC7eEW+xhRJ/SliclBQrETHBWQNcvncHhs8xbU66VpgJ8STk3QIDt/X0xa Kdl6ovF7BhPiw== Date: Sat, 11 Jun 2022 17:31:03 +0800 From: Shawn Guo To: Ulrich =?iso-8859-1?Q?=D6lmann?= Cc: Rob Herring , Krzysztof Kozlowski , Sascha Hauer , NXP Linux Team , Fabio Estevam , Pengutronix Kernel Team , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Oleksij Rempel , Juergen Borleis , Michael Grzeschik , Marco Felsch , Lucas Stach , =?iso-8859-1?Q?S=F8ren?= Andersen , Sam Ravnborg Subject: Re: [PATCH] ARM: dts: imx6: skov: add pwm-regulator to control the panel's VCOM Message-ID: <20220611093103.GI254723@dragon> References: <20220517071814.3626702-1-u.oelmann@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220517071814.3626702-1-u.oelmann@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2022 at 09:18:14AM +0200, Ulrich Ölmann wrote: > Skov's i.MX6 based boards come in different flavors which have different panels > attached. For optimal contrast experience each panel type needs an individual > common voltage (VCOM) to drive its TFT backplane. The latter is generated by an > LCD bias supply IC controlled by a pwm as input signal. Introduce a pwm- > regulator to describe this hardware property and parameterize it appropriately > for the different boards. > > Signed-off-by: Ulrich Ölmann > --- > arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dts | 6 ++++++ > arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi | 10 ++++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dts b/arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dts > index 7f1f19b74bfa..a3f247c722b4 100644 > --- a/arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dts > +++ b/arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dts > @@ -125,3 +125,9 @@ MX6QDL_PAD_EIM_D23__GPIO3_IO23 0x1b0b0 > >; > }; > }; > + > +®_tft_vcom { > + regulator-min-microvolt = <3160000>; > + regulator-max-microvolt = <3160000>; > + voltage-table = <3160000 73>; > +}; > diff --git a/arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi b/arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi > index 77a91a97e6cf..3def1b621c8e 100644 > --- a/arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi > @@ -149,6 +149,16 @@ reg_can2_stby: regulator-can2-stby { > gpio = <&gpio4 11 GPIO_ACTIVE_LOW>; > }; > > + reg_tft_vcom: regulator-tft-vcom { > + compatible = "pwm-regulator"; > + pwms = <&pwm3 0 20000 0>; > + regulator-name = "tft_vcom"; > + regulator-min-microvolt = <3600000>; > + regulator-max-microvolt = <3600000>; > + regulator-always-on; You want it to be unmanaged and always-on? Shawn > + voltage-table = <3600000 26>; > + }; > + > reg_vcc_mmc: regulator-vcc-mmc { > compatible = "regulator-fixed"; > pinctrl-names = "default"; > -- > 2.30.2 >