From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3876CCA47E for ; Mon, 13 Jun 2022 08:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239525AbiFMIHQ (ORCPT ); Mon, 13 Jun 2022 04:07:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234954AbiFMIGs (ORCPT ); Mon, 13 Jun 2022 04:06:48 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CD8A193D5 for ; Mon, 13 Jun 2022 01:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655107607; x=1686643607; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=gwxLCDMvuI9jTp3aOqw0S9fllcBjdOln7NM/mKbpqHs=; b=VMJO6WoR9OYcEmUu6SEXsFT4uDRdRuwccRGw1lj7wbTKlDJXx6dRbJ67 XzC7zmcZo8fJnQiuNfHGqigRJMp3hVVSzFOWgNurNYg+//r4ojFSdSaJh V7ynAJnku4rzcPZ/2yIYehqorrPSykL8ls/Tl7G840F4XMKFa7gpJbWjr K8/sc6qXae+L5rvrRHLks4HSdOdmGZdLrCgc+Gb1g5vLmjvWrxjzBA6Ii 1O1R+dbIpz7QCOWLusYzWGUIbjEtCBtei2jnZMe05mOAUrYNTiCEY/KMM kcwScVe8E9u8hm8IFhUsyOlaZLcuZE6kBds2E51cwCXqFMNsszoEDowvt Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10376"; a="364534105" X-IronPort-AV: E=Sophos;i="5.91,296,1647327600"; d="scan'208";a="364534105" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2022 01:06:47 -0700 X-IronPort-AV: E=Sophos;i="5.91,296,1647327600"; d="scan'208";a="673147817" Received: from xiruzha-mobl1.ccr.corp.intel.com (HELO chenyu5-mobl1) ([10.249.169.88]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2022 01:06:40 -0700 Date: Mon, 13 Jun 2022 16:06:36 +0800 From: Chen Yu To: Yicong Yang Cc: Peter Zijlstra , Vincent Guittot , Mel Gorman , yangyicong@hisilicon.com, Ingo Molnar , Juri Lelli , Dietmar Eggemann , Steven Rostedt , Barry Song <21cnbao@gmail.com>, Srikar Dronamraju , Len Brown , Ben Segall , Aubrey Li , Abel Wu , Daniel Bristot de Oliveira , Tim Chen , linux-kernel@vger.kernel.org, K Prateek Nayak , Mohini Narkhede Subject: Re: [PATCH v4] sched/fair: Introduce SIS_UTIL to search idle CPU based on sum of util_avg Message-ID: <20220613080636.GA32587@chenyu5-mobl1> References: <20220612163428.849378-1-yu.c.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 13, 2022 at 03:40:52PM +0800, Yicong Yang wrote: > On 2022/6/13 0:34, Chen Yu wrote: > > [cut...] > > #define NUMA_IMBALANCE_MIN 2 > > diff --git a/kernel/sched/features.h b/kernel/sched/features.h > > index 1cf435bbcd9c..3334a1b93fc6 100644 > > --- a/kernel/sched/features.h > > +++ b/kernel/sched/features.h > > @@ -61,6 +61,7 @@ SCHED_FEAT(TTWU_QUEUE, true) > > * When doing wakeups, attempt to limit superfluous scans of the LLC domain. > > */ > > SCHED_FEAT(SIS_PROP, true) > > +SCHED_FEAT(SIS_UTIL, true) > > > > confused here that shouldn't we have SCHED_FEAT(SIS_PROP, false)? With SIS_UTIL enabled, SIS_PROP will have no > effect since nr is overridden by SIS_UTIL. Yes, no matter what SIS_PROP is set, the result of SIS_UTIL would be used to decide the scan depth. We don't change the default value of SIS_PROP here, as this patch tends to only touch one feature at one time. And the options could be tuned by user via sysfs manually. Besides, the target is to replace SIS_PROP with another search policy, Peter mentioned that "And ideally we're remove SIS_PROP after a few releases if this works out", so I assume that changing the default value of SIS_PROP does not matter in current patch. thanks, Chenyu