Re: [PATCH 00/06] fid refcounting improvements and fixes

Tyler Hicks
2022-06-14T01:15:02Z

On 2022-06-14 06:00:21, Dominique Martinet wrote:
> Tyler Hicks wrote on Mon, Jun 13, 2022 at 03:20:53PM -0500:
> > On 2022-06-12 17:53:23, Dominique Martinet wrote:
> > > @@ -222,7 +221,8 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct dentry *dentry,
> > > * We need to hold rename lock when doing a multipath
> > > * walk to ensure none of the patch component change
> > > */
> > > - fid = p9_client_walk(old_fid, l, &wnames[i], clone);
> > > + fid = p9_client_walk(old_fid, l, &wnames[i],
> > > + old_fid == root_fid /* clone */);
> >
> > This is no problem at all. The rebased patches look good to me. Squash
> > your fix to my fix and it should be ready to go.
>
> Thanks for all your reviews :)
> I've rebased my branch if you want to check:
> https://github.com/martinetd/linux/commits/9p-next

I've diffed the individual patches from before and after the rebase. It
all looks great to me.

> We've just started a cycle so I'll submit the first three patches (fixes
> to stable) next week, and the rest for when 5.20 cycle starts.

That sounds like the right plan to me.

> Feel free to remind me if it looks like I forgot.

Will do!

Tyler

> --
> Dominique
>