Re: [PATCH v4 13/18] PCI: dwc: Add start_link/stop_link inliners

Rob Herring
2022-06-13T21:06:00Z

On Fri, Jun 10, 2022 at 11:25:29AM +0300, Serge Semin wrote:
> There are several places in the generic DW PCIe code where the
> platform-specific PCIe link start/stop methods are called after making
> sure the ops handler and the callbacks are specified. Instead of repeating
> the same pattern over and over let's define the static-inline methods in
> the DW PCIe header file and use them in the relevant parts of the driver.
>
> Note returning a negative error from the EP link start procedure if the
> start_link pointer isn't specified doesn't really make much sense since it
> perfectly normal to have such platform. Moreover even pci_epc_start()
> doesn't fail if no epc->ops->start callback is spotted. As a side-effect
> of this modification we can set the generic DW PCIe and Layerscape EP
> platform drivers free from the empty start_link callbacks and as such
> entirely dummy dw_pcie_ops instances.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> ---
>
> Changelog v4:
> - This is a new patch created on the v4 lap of the series.
> ---
> drivers/pci/controller/dwc/pci-layerscape-ep.c | 12 ------------
> drivers/pci/controller/dwc/pcie-designware-ep.c | 8 ++------
> drivers/pci/controller/dwc/pcie-designware-host.c | 10 ++++------
> drivers/pci/controller/dwc/pcie-designware-plat.c | 10 ----------
> drivers/pci/controller/dwc/pcie-designware.h | 14 ++++++++++++++
> 5 files changed, 20 insertions(+), 34 deletions(-)

Reviewed-by: Rob Herring <robh@kernel.org>