Re: [PATCH v4 05/18] PCI: dwc: Deallocate EPC memory on EP init error

Rob Herring
2022-06-13T20:57:29Z

On Fri, Jun 10, 2022 at 11:25:21AM +0300, Serge Semin wrote:
> If the dw_pcie_ep_init() method fails to perform any action after the EPC
> memory is initialized and the MSI memory region is allocated, the later
> parts won't be undone thus causing the memory leak. Let's fix that by
> introducing the cleanup-on-error path in the dw_pcie_ep_init() method,
> which will be taken should any consequent erroneous situation happens.
>
> Fixes: 2fd0c9d966cc ("PCI: designware-ep: Pre-allocate memory for MSI in dw_pcie_ep_init")
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> ---
>
> Changelog v2:
> - This is a new patch create as a result of the discussion in:
> Link: https://lore.kernel.org/linux-pci/20220324014836.19149-26-Sergey.Semin@baikalelectronics.ru
> ---
> .../pci/controller/dwc/pcie-designware-ep.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)

Reviewed-by: Rob Herring <robh@kernel.org>