From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB234CCA47B for ; Tue, 14 Jun 2022 02:06:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351609AbiFNCGI (ORCPT ); Mon, 13 Jun 2022 22:06:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346107AbiFNCFY (ORCPT ); Mon, 13 Jun 2022 22:05:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B160344C5; Mon, 13 Jun 2022 19:05:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E5A3B60AEC; Tue, 14 Jun 2022 02:05:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53769C3411E; Tue, 14 Jun 2022 02:05:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655172315; bh=tzW7zB6n+0Qkd9R+/zK1+fs/LETpXudDWxsaCRdi3+k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ValVdvR5n819wgVN8RsPMz7pU1pUR6qpjGHKjwSyKORtjTPN6yVr1Q2qF7AlkXqs/ Vv8GOihUHbCDbmJiuk+C/K9Madqyz3s4ghLzlq2u8McAx5uu4hbJsermStXKDKs8pp l+WHB3afhUjxvbNRgZfWNAD7KF4sZAn5KKrl21ymiEG1nWD82JLyGk6n/coOia9gRE Jca2Nohxj1xPhWXuoSDqxnbNZhEmU8P7hWao4m+UgI4bg5ux0LjSZh6VLdrHAhJe8x MgIYRgaDLH7rq/1/WK7FQubztc0C/geU7Wty3IZ41WEl9HdWAY6tyDfGRYlLT4TqiD /9vNBWm+0zg9w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mark Brown , Sasha Levin , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.18 19/47] ASoC: es8328: Fix event generation for deemphasis control Date: Mon, 13 Jun 2022 22:04:12 -0400 Message-Id: <20220614020441.1098348-19-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220614020441.1098348-1-sashal@kernel.org> References: <20220614020441.1098348-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Brown [ Upstream commit 8259610c2ec01c5cbfb61882ae176aabacac9c19 ] Currently the put() method for the deemphasis control returns 0 when a new value is written to the control even if the value changed, meaning events are not generated. Fix this, skip the work of updating the value when it is unchanged and then return 1 after having done so. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220603123937.4013603-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/es8328.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c index 3f00ead97006..dd53dfd87b04 100644 --- a/sound/soc/codecs/es8328.c +++ b/sound/soc/codecs/es8328.c @@ -161,13 +161,16 @@ static int es8328_put_deemph(struct snd_kcontrol *kcontrol, if (deemph > 1) return -EINVAL; + if (es8328->deemph == deemph) + return 0; + ret = es8328_set_deemph(component); if (ret < 0) return ret; es8328->deemph = deemph; - return 0; + return 1; } -- 2.35.1