From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 244D5CCA47B for ; Tue, 14 Jun 2022 02:06:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350981AbiFNCGu (ORCPT ); Mon, 13 Jun 2022 22:06:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351477AbiFNCGE (ORCPT ); Mon, 13 Jun 2022 22:06:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EFB834642; Mon, 13 Jun 2022 19:05:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 26B1D60AD8; Tue, 14 Jun 2022 02:05:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A208EC3411B; Tue, 14 Jun 2022 02:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655172331; bh=jnvaKL2ylP9hoy1It4rGwhTXwZO5J+36jAw+FL5Cfcs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HfXrG8prc4whURDuR0cSAFapFOeym1LXHXVBarRz6gcuqlOSOsAdTorXyfRUjuYyc fHqcd3oiub1aZAgYbNe+MXGP/65g6l3PAxqpXhtIfFeoE8d+ixIvITLvi3gjl/579e weJaZAcpDboRW7o0GkAwBhDYiyiGEucz49GiUHc5B0g+VNtoqi2fQwArldK02OHTf6 RRcipPk3CwRyWqGUzUjuo1LS5QdKaXrU4crOawfL+AuPY/i4atdhgvM1SMP7m/GJW7 Hxb8FAk+kCG6L2WhoobHc1wZ3F0NFG/fnnweWSUOqiU5lQ6XgqzA3IUDN1jusRwPiT OF05TPRk/ZGeA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chengguang Xu , Dan Carpenter , "Martin K . Petersen" , Sasha Levin , jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.18 29/47] scsi: pmcraid: Fix missing resource cleanup in error case Date: Mon, 13 Jun 2022 22:04:22 -0400 Message-Id: <20220614020441.1098348-29-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220614020441.1098348-1-sashal@kernel.org> References: <20220614020441.1098348-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chengguang Xu [ Upstream commit ec1e8adcbdf661c57c395bca342945f4f815add7 ] Fix missing resource cleanup (when '(--i) == 0') for error case in pmcraid_register_interrupt_handler(). Link: https://lore.kernel.org/r/20220529153456.4183738-6-cgxu519@mykernel.net Reviewed-by: Dan Carpenter Signed-off-by: Chengguang Xu Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/pmcraid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index fd674ed1febe..6d94837c9049 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -4031,7 +4031,7 @@ pmcraid_register_interrupt_handler(struct pmcraid_instance *pinstance) return 0; out_unwind: - while (--i > 0) + while (--i >= 0) free_irq(pci_irq_vector(pdev, i), &pinstance->hrrq_vector[i]); pci_free_irq_vectors(pdev); return rc; -- 2.35.1