From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17FECC433EF for ; Tue, 14 Jun 2022 02:05:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350735AbiFNCFN (ORCPT ); Mon, 13 Jun 2022 22:05:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348324AbiFNCFB (ORCPT ); Mon, 13 Jun 2022 22:05:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6149430554; Mon, 13 Jun 2022 19:04:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ECB6D60AF2; Tue, 14 Jun 2022 02:04:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A558DC3411E; Tue, 14 Jun 2022 02:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655172295; bh=jpahqU4Ez2Jv2ovq+6xWJVXthFohCC2sf6mGPWztRhY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DnV/KFYk8Zb4ClWS3Htrif2hSytFcUYzbA3x5t1qqRt+fs723Qgs6pYSNSAiSp5qZ QtE1uKhx7LOv9gIOAu1TASgSy7mmXdwhvw69CfOs6FqR3B3cBrbIgfJktv/N8+oJuQ LZIzx6w6ftQ+y3uxRGRoKLeNXfWJeUGeY6KjBplhI5JYajQqfgK3CUkdubz2Wg5hNQ 8aJl2NG2E5vwlORrZBUsDdM9Sew5QcOBztbnsS0s/GAZCBEty6bAFEkN/zXxhqeJmS Kkw9iAwm36DKp8kJW9NYvKRU6pEEySuyhduZ9uovqmn+r2jgLmWTzvHK/gOXyjJAV3 5jaM5Jk0dbPbg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Rob Clark , Christoph Hellwig , Sasha Levin Subject: [PATCH AUTOSEL 5.18 07/47] dma-debug: make things less spammy under memory pressure Date: Mon, 13 Jun 2022 22:04:00 -0400 Message-Id: <20220614020441.1098348-7-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220614020441.1098348-1-sashal@kernel.org> References: <20220614020441.1098348-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rob Clark [ Upstream commit e19f8fa6ce1ca9b8b934ba7d2e8f34c95abc6e60 ] Limit the error msg to avoid flooding the console. If you have a lot of threads hitting this at once, they could have already gotten passed the dma_debug_disabled() check before they get to the point of allocation failure, resulting in quite a lot of this error message spamming the log. Use pr_err_once() to limit that. Signed-off-by: Rob Clark Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- kernel/dma/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c index ac740630c79c..2caafd13f8aa 100644 --- a/kernel/dma/debug.c +++ b/kernel/dma/debug.c @@ -564,7 +564,7 @@ static void add_dma_entry(struct dma_debug_entry *entry, unsigned long attrs) rc = active_cacheline_insert(entry); if (rc == -ENOMEM) { - pr_err("cacheline tracking ENOMEM, dma-debug disabled\n"); + pr_err_once("cacheline tracking ENOMEM, dma-debug disabled\n"); global_disable = true; } else if (rc == -EEXIST && !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) { err_printk(entry->dev, entry, -- 2.35.1