public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: xliu <xiang.liu@cirrus.com>, Brent Lu <brent.lu@intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>,
	lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
	alsa-devel@alsa-project.org
Subject: [PATCH AUTOSEL 5.18 08/47] ASoC: Intel: cirrus-common: fix incorrect channel mapping
Date: Mon, 13 Jun 2022 22:04:01 -0400	[thread overview]
Message-ID: <20220614020441.1098348-8-sashal@kernel.org> (raw)
In-Reply-To: <20220614020441.1098348-1-sashal@kernel.org>

From: xliu <xiang.liu@cirrus.com>

[ Upstream commit d69a155555c9d57463b788c400f6b452d976bacd ]

The default mapping of ASPRX1 (DAC source) is slot 0. Change the slot
mapping of right amplifiers (WR and TR) to slot 1 to receive right
channel data. Also update the ACPI instance ID mapping according to HW
configuration.

Signed-off-by: xliu <xiang.liu@cirrus.com>
Signed-off-by: Brent Lu <brent.lu@intel.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220602051922.1232457-1-brent.lu@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 sound/soc/intel/boards/sof_cirrus_common.c | 40 +++++++++++++++++++---
 1 file changed, 36 insertions(+), 4 deletions(-)

diff --git a/sound/soc/intel/boards/sof_cirrus_common.c b/sound/soc/intel/boards/sof_cirrus_common.c
index e71d74ec1b0b..f4192df962d6 100644
--- a/sound/soc/intel/boards/sof_cirrus_common.c
+++ b/sound/soc/intel/boards/sof_cirrus_common.c
@@ -54,22 +54,29 @@ static struct snd_soc_dai_link_component cs35l41_components[] = {
 	},
 };
 
+/*
+ * Mapping between ACPI instance id and speaker position.
+ *
+ * Four speakers:
+ *         0: Tweeter left, 1: Woofer left
+ *         2: Tweeter right, 3: Woofer right
+ */
 static struct snd_soc_codec_conf cs35l41_codec_conf[] = {
 	{
 		.dlc = COMP_CODEC_CONF(CS35L41_DEV0_NAME),
-		.name_prefix = "WL",
+		.name_prefix = "TL",
 	},
 	{
 		.dlc = COMP_CODEC_CONF(CS35L41_DEV1_NAME),
-		.name_prefix = "WR",
+		.name_prefix = "WL",
 	},
 	{
 		.dlc = COMP_CODEC_CONF(CS35L41_DEV2_NAME),
-		.name_prefix = "TL",
+		.name_prefix = "TR",
 	},
 	{
 		.dlc = COMP_CODEC_CONF(CS35L41_DEV3_NAME),
-		.name_prefix = "TR",
+		.name_prefix = "WR",
 	},
 };
 
@@ -101,6 +108,21 @@ static int cs35l41_init(struct snd_soc_pcm_runtime *rtd)
 	return ret;
 }
 
+/*
+ * Channel map:
+ *
+ * TL/WL: ASPRX1 on slot 0, ASPRX2 on slot 1 (default)
+ * TR/WR: ASPRX1 on slot 1, ASPRX2 on slot 0
+ */
+static const struct {
+	unsigned int rx[2];
+} cs35l41_channel_map[] = {
+	{.rx = {0, 1}}, /* TL */
+	{.rx = {0, 1}}, /* WL */
+	{.rx = {1, 0}}, /* TR */
+	{.rx = {1, 0}}, /* WR */
+};
+
 static int cs35l41_hw_params(struct snd_pcm_substream *substream,
 			     struct snd_pcm_hw_params *params)
 {
@@ -134,6 +156,16 @@ static int cs35l41_hw_params(struct snd_pcm_substream *substream,
 				ret);
 			return ret;
 		}
+
+		/* setup channel map */
+		ret = snd_soc_dai_set_channel_map(codec_dai, 0, NULL,
+						  ARRAY_SIZE(cs35l41_channel_map[i].rx),
+						  (unsigned int *)cs35l41_channel_map[i].rx);
+		if (ret < 0) {
+			dev_err(codec_dai->dev, "fail to set channel map, ret %d\n",
+				ret);
+			return ret;
+		}
 	}
 
 	return 0;
-- 
2.35.1


  parent reply	other threads:[~2022-06-14  2:05 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  2:03 [PATCH AUTOSEL 5.18 01/47] powerpc/kasan: Silence KASAN warnings in __get_wchan() Sasha Levin
2022-06-14  2:03 ` [PATCH AUTOSEL 5.18 02/47] ASoC: nau8822: Add operation for internal PLL off and on Sasha Levin
2022-06-14  2:03 ` [PATCH AUTOSEL 5.18 03/47] ASoC: qcom: lpass-platform: Update VMA access permissions in mmap callback Sasha Levin
2022-06-14  2:03 ` [PATCH AUTOSEL 5.18 04/47] drm/amd/display: Read Golden Settings Table from VBIOS Sasha Levin
2022-06-14  2:03 ` [PATCH AUTOSEL 5.18 05/47] drm/amdgpu: Resolve RAS GFX error count issue after cold boot on Arcturus Sasha Levin
2022-06-14  2:03 ` [PATCH AUTOSEL 5.18 06/47] drm/amdkfd: Use mmget_not_zero in MMU notifier Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 07/47] dma-debug: make things less spammy under memory pressure Sasha Levin
2022-06-14  2:04 ` Sasha Levin [this message]
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 09/47] ASoC: cs42l52: Fix TLV scales for mixer controls Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 10/47] ASoC: cs35l36: Update digital volume TLV Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 11/47] ASoC: cs53l30: Correct number of volume levels on SX controls Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 12/47] ASoC: cs42l52: Correct TLV for Bypass Volume Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 13/47] ASoC: cs42l56: Correct typo in minimum level for SX volume controls Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 14/47] ASoC: cs42l51: Correct minimum value for SX volume control Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 15/47] drm/amdkfd: add pinned BOs to kfd_bo_list Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 16/47] ata: libata-core: fix NULL pointer deref in ata_host_alloc_pinfo() Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 17/47] quota: Prevent memory allocation recursion while holding dq_lock Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 18/47] ASoC: wm8962: Fix suspend while playing music Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 19/47] ASoC: es8328: Fix event generation for deemphasis control Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 20/47] ASoC: wm_adsp: Fix event generation for wm_adsp_fw_put() Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 21/47] ALSA: hda: MTL: add HD Audio PCI ID and HDMI codec vendor ID Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 22/47] Input: soc_button_array - also add Lenovo Yoga Tablet2 1051F to dmi_use_low_level_irq Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 23/47] scsi: vmw_pvscsi: Expand vcpuHint to 16 bits Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 24/47] scsi: lpfc: Resolve NULL ptr dereference after an ELS LOGO is aborted Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 25/47] scsi: lpfc: Fix port stuck in bypassed state after LIP in PT2PT topology Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 26/47] scsi: lpfc: Allow reduced polling rate for nvme_admin_async_event cmd completion Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 27/47] scsi: mpt3sas: Fix out-of-bounds compiler warning Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 28/47] scsi: ipr: Fix missing/incorrect resource cleanup in error case Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 29/47] scsi: pmcraid: Fix missing " Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 30/47] ALSA: hda/realtek - Add HW8326 support Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 31/47] virtio-mmio: fix missing put_device() when vm_cmdline_parent registration failed Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 32/47] nfc: nfcmrvl: Fix memory leak in nfcmrvl_play_deferred Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 33/47] ipv6: Fix signed integer overflow in __ip6_append_data Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 34/47] ipv6: Fix signed integer overflow in l2tp_ip6_sendmsg Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 35/47] net: ethernet: mtk_eth_soc: fix misuse of mem alloc interface netdev[napi]_alloc_frag Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 36/47] gcc-12: disable '-Wdangling-pointer' warning for now Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 37/47] mellanox: mlx5: avoid uninitialized variable warning with gcc-12 Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 38/47] gcc-12: disable '-Warray-bounds' universally for now Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 39/47] netfs: gcc-12: temporarily disable '-Wattribute-warning' " Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 40/47] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 41/47] random: credit cpu and bootloader seeds by default Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 42/47] gpio: dwapb: Don't print error on -EPROBE_DEFER Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 43/47] platform/x86/intel: Fix pmt_crashlog array reference Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 44/47] platform/x86/intel: pmc: Support Intel Raptorlake P Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 45/47] platform/x86: gigabyte-wmi: Add Z690M AORUS ELITE AX DDR4 support Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 46/47] platform/x86: gigabyte-wmi: Add support for B450M DS3H-CF Sasha Levin
2022-06-14  2:04 ` [PATCH AUTOSEL 5.18 47/47] platform/x86/intel: hid: Add Surface Go to VGBS allow list Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220614020441.1098348-8-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=brent.lu@intel.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=xiang.liu@cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox