From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58A9FC43334 for ; Tue, 14 Jun 2022 02:24:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354630AbiFNCX1 (ORCPT ); Mon, 13 Jun 2022 22:23:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354567AbiFNCTZ (ORCPT ); Mon, 13 Jun 2022 22:19:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E76173ED38; Mon, 13 Jun 2022 19:09:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 34E6760C15; Tue, 14 Jun 2022 02:09:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6F1FC341C4; Tue, 14 Jun 2022 02:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655172573; bh=AdFVJd7dV+iDxxJ8is6cJt2zyE1ZZxlOE5i/rQvNwmA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PHxcHpET/lxLlVH6Fb0Qm1mzl4r+zSVnbqtdEAgoBkRnKrWtCeVB+XEKfijBCPKWk sHcSl0aLhZsh8MkxXQCWoHM4prB3c2Oy25Zpq0HUTWlDp+zPyxXJd+Ql+81lOtCXSJ 6eAUw+c+avk/75QZavRj0/rxKATJpn/rLfwcsTdd/6L59nwungHKKpz+ChKmfKY7cJ x4WqHMteOrDQpLitcx5TlqY0EZ5o822SCzFq22TwVZrugrJW+lcMoj5W72ZaaBtANF +rVLA8VdVKLRCevvdx/MgAbJF1bTYBsv/dyw8Fsd3Id+cPyxRmHG8xGwDQ5LziYM3+ CtotspUUDCU5Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: chengkaitao , "Michael S . Tsirkin" , Jason Wang , Sasha Levin , virtualization@lists.linux-foundation.org Subject: [PATCH AUTOSEL 5.4 19/23] virtio-mmio: fix missing put_device() when vm_cmdline_parent registration failed Date: Mon, 13 Jun 2022 22:08:55 -0400 Message-Id: <20220614020900.1100401-19-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220614020900.1100401-1-sashal@kernel.org> References: <20220614020900.1100401-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: chengkaitao [ Upstream commit a58a7f97ba11391d2d0d408e0b24f38d86ae748e ] The reference must be released when device_register(&vm_cmdline_parent) failed. Add the corresponding 'put_device()' in the error handling path. Signed-off-by: chengkaitao Message-Id: <20220602005542.16489-1-chengkaitao@didiglobal.com> Signed-off-by: Michael S. Tsirkin Acked-by: Jason Wang Signed-off-by: Sasha Levin --- drivers/virtio/virtio_mmio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index e09edb5c5e06..74547323aa83 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -669,6 +669,7 @@ static int vm_cmdline_set(const char *device, if (!vm_cmdline_parent_registered) { err = device_register(&vm_cmdline_parent); if (err) { + put_device(&vm_cmdline_parent); pr_err("Failed to register parent device!\n"); return err; } -- 2.35.1