From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 223FAC433EF for ; Tue, 14 Jun 2022 02:25:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354980AbiFNCZp (ORCPT ); Mon, 13 Jun 2022 22:25:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353982AbiFNCXB (ORCPT ); Mon, 13 Jun 2022 22:23:01 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCBA5369D0; Mon, 13 Jun 2022 19:10:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5AA76B816A3; Tue, 14 Jun 2022 02:10:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 384EFC341C5; Tue, 14 Jun 2022 02:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655172605; bh=Fw48xkHyH8/DLVrsed+YMJXLK35lFF9hd1liV4MKg1E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QxHGMRs6PAj7VTen6LIE8QXlQoxjQRRaMbKVw8KkBA1XT8z3pBeuJPbFkg9PfX08r AtQ5uqOUevR/AxQr3Bx68HjJM1T4BDKDwIuoXWa4Z+S8i5kbPbSZYnAKl1XJPPPbMu XzWut3AtT8so0S/rUPzP8Eq4HFwtx+TsbEHOcEk/GSMd2O7uOSOSPyUKOLm8+azH2+ njRG8xBXQzdqMUVqq0/Bb+jA0P3xaEeGa8lFUSQMmUp61Q82NjfrqD8jsk6sreOARz m4PQcmlhDjQFZpOz+YqwiS6rQlbEoxKCNnHH1QpiikmQuM30MUTtTXLsmm3PBjKb6V 3td3oOfwHpZbA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mark Brown , Sasha Levin , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 4.19 08/18] ASoC: es8328: Fix event generation for deemphasis control Date: Mon, 13 Jun 2022 22:09:31 -0400 Message-Id: <20220614020941.1100702-8-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220614020941.1100702-1-sashal@kernel.org> References: <20220614020941.1100702-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Brown [ Upstream commit 8259610c2ec01c5cbfb61882ae176aabacac9c19 ] Currently the put() method for the deemphasis control returns 0 when a new value is written to the control even if the value changed, meaning events are not generated. Fix this, skip the work of updating the value when it is unchanged and then return 1 after having done so. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220603123937.4013603-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/es8328.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c index 3afa163f7652..dcb01889e177 100644 --- a/sound/soc/codecs/es8328.c +++ b/sound/soc/codecs/es8328.c @@ -165,13 +165,16 @@ static int es8328_put_deemph(struct snd_kcontrol *kcontrol, if (deemph > 1) return -EINVAL; + if (es8328->deemph == deemph) + return 0; + ret = es8328_set_deemph(component); if (ret < 0) return ret; es8328->deemph = deemph; - return 0; + return 1; } -- 2.35.1