Re: [PATCH 03/20] block, blksnap: module management interface functions

Chaitanya Kulkarni
2022-06-13T22:44:29Z

> +static int ioctl_snapshot_wait_event(unsigned long arg)
> +{
> + int ret = 0;
> + struct blk_snap_snapshot_event *karg;
> + struct event *event;
> +
> + //pr_debug("Wait event\n");

please avoid avove comment style and remove debug statements.

> + karg = kzalloc(sizeof(struct blk_snap_snapshot_event), GFP_KERNEL);
> + if (!karg)
> + return -ENOMEM;

-ck