From: Dan Carpenter <dan.carpenter@oracle.com>
To: daniel watson <ozzloy@challenge-bot.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WRF_cmd
Date: Tue, 14 Jun 2022 17:47:34 +0300 [thread overview]
Message-ID: <20220614144734.GK2146@kadam> (raw)
In-Reply-To: <3797496ad258ba3d0184b82194c6db729eff28d9.1655171591.git.ozzloy@challenge-bot.com>
On Mon, Jun 13, 2022 at 07:07:33PM -0700, daniel watson wrote:
> From: Daniel Watson <ozzloy@challenge-bot.com>
>
> name the function rtw_IOL_append_WRF_cmd and call it directly,
^^^^^^^^
Where is the first part of the sentence?
> instead of using wrapper macro
>
> delete wrapper macro, which is not needed
>
> NOTE: code compiles, not tested on hardware
>
> Signed-off-by: Daniel Watson <ozzloy@challenge-bot.com>
>
> staging: r8188eu: remove leading '_' on _rtw_IOL_append_WRF_cmd
>
> call rtw_IOL_append_WRF_cmd directly instead of using wrapper macro
This is a better commit message but use a capital C "Call".
> delete wrapper macro, which is not needed
>
> NOTE: code compiles, not tested on hardware
>
> Signed-off-by: Daniel Watson <ozzloy@challenge-bot.com>
You have the commit message twice.
regards,
dan carpenter
prev parent reply other threads:[~2022-06-14 14:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 2:07 [PATCH 0/4] remove wrappers on _rtw_IOL_append_*_cmd daniel watson
2022-06-14 2:07 ` [PATCH 1/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WB_cmd daniel watson
2022-06-14 14:42 ` Dan Carpenter
2022-06-14 2:07 ` [PATCH 2/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WW_cmd daniel watson
2022-06-14 2:07 ` [PATCH 3/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WD_cmd daniel watson
2022-06-14 2:07 ` [PATCH 4/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WRF_cmd daniel watson
2022-06-14 14:47 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614144734.GK2146@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ozzloy@challenge-bot.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox