From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39166CCA47A for ; Tue, 14 Jun 2022 15:18:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356619AbiFNPS5 (ORCPT ); Tue, 14 Jun 2022 11:18:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343593AbiFNPSz (ORCPT ); Tue, 14 Jun 2022 11:18:55 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2A9D2F38C; Tue, 14 Jun 2022 08:18:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5D647B81983; Tue, 14 Jun 2022 15:18:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9EBFC3411C; Tue, 14 Jun 2022 15:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655219932; bh=J2nvep70ztufiXjK8zkqurUdHaOco9RVIdWlW0n//ik=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ZipO5ZUCf6/omUHuCtPPDid9mJmPTsQbtBfZJv3CZXICjksUqnCCcTqGd0Caj5S0Y er2IByOB7/FLY9qdimOGr/UILfocQXjY4bADekWWr7aKPuF34r/XJwbt2kf448nwiK viNdfrEyxe3GtZAEVGN9hIkgJnnSsLjTxRsB8SS/JyRoQ3RHVGcsFZOtrxbpmpRWTM iO9JPu2qKHF759X/LF5VjZzuf/nbgEmU46wlwuA57QGeJhTGsTlqPJYk/ZhXPWY/iX J9dVcNzzU5V6PB+vw/o0FAKkpG7rpBfszgE9g9sE0H5/1LCLppVXb0IeUHnmXE99TZ 4O4CL1BXKDO5A== Date: Tue, 14 Jun 2022 10:18:50 -0500 From: Bjorn Helgaas To: Andy Shevchenko Cc: "Gustavo A. R. Silva" , Bjorn Helgaas , Hans de Goede , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ferry Toth Subject: Re: [PATCH v1 1/1] x86/PCI: Disable e820 usage for the resource allocation Message-ID: <20220614151850.GA756316@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 14, 2022 at 02:55:42PM +0300, Andy Shevchenko wrote: > On Mon, Jun 13, 2022 at 05:35:20PM -0500, Bjorn Helgaas wrote: > > On Mon, Jun 13, 2022 at 11:16:41PM +0300, Andy Shevchenko wrote: > > > The resource management improve for PCI on x86 broke booting of Intel MID > > > platforms. It seems that the current code removes all available resources > > > from the list and none of the PCI device may be initialized. Restore the > > > old behaviour by force disabling the e820 usage for the resource allocation. > > > > > > Fixes: 4c5e242d3e93 ("x86/PCI: Clip only host bridge windows for E820 regions") > > > Depends-on: fa6dae5d8208 ("x86/PCI: Add kernel cmdline options to use/ignore E820 reserved regions") > > > Signed-off-by: Andy Shevchenko > > > > Yeah, I blew it with 4c5e242d3e93. Can you provide more details on > > how the MID platforms broke? > > It's not so easy. The breakage seems affects the console driver and earlycon > doesn't work. erlyprintk doesn't support 32-bit MMIO addresses (again, > addresses, not data size). That said, there is nothing to show at all. > > What I did, I have bisected to your patch, commented out the call and instead > added a printk() to see what it does, and it basically removed all resources > listed in _CRS. > > > Since you set "pci_use_e820 = false" for > > MID below, I assume MID doesn't depend on the e820 clipping and thus > > should not break if we turn off clipping by default in 2023 as in > > 0ae084d5a674 ("x86/PCI: Disable E820 reserved region clipping starting > > in 2023"). > > > But it'd be nice to see the dmesg log and make sure. > > Nothing to provide (see above why), sorry. A dmesg log with a working kernel, especially from one with Hans' revert, which might have a little more logging about clipping, might have enough info to help figure this out. Bjorn