Re: [PATCH v2 1/5] PM / devfreq: Fix cpufreq passive unregister erroring on PROBE_DEFER

[kernel test robot <lkp@intel.com>]

Hi Christian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on chanwoo/devfreq-testing]
[also build test ERROR on linus/master v5.19-rc2 next-20220614]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Ansuel-Marangi/PM-devfreq-Various-Fixes-to-cpufreq-based-passive-governor/20220614-020616
base:   https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git devfreq-testing
config: arc-randconfig-r043-20220613 (https://download.01.org/0day-ci/archive/20220614/202206141647.zyZy1pSw-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/378807dd7da24162524c0ba84e996157b3e289c6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Christian-Ansuel-Marangi/PM-devfreq-Various-Fixes-to-cpufreq-based-passive-governor/20220614-020616
        git checkout 378807dd7da24162524c0ba84e996157b3e289c6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/devfreq/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/devfreq/governor_passive.c: In function 'cpufreq_passive_unregister_notifier':
>> drivers/devfreq/governor_passive.c:235:79: error: macro "list_for_each_entry_safe" requires 4 arguments, but only 3 given
     235 |         list_for_each_entry_safe(parent_cpu_data, &p_data->cpu_data_list, node) {
         |                                                                               ^
   In file included from include/linux/module.h:12,
                    from drivers/devfreq/governor_passive.c:10:
   include/linux/list.h:760: note: macro "list_for_each_entry_safe" defined here
     760 | #define list_for_each_entry_safe(pos, n, head, member)                  \
         | 
>> drivers/devfreq/governor_passive.c:235:9: error: 'list_for_each_entry_safe' undeclared (first use in this function)
     235 |         list_for_each_entry_safe(parent_cpu_data, &p_data->cpu_data_list, node) {
         |         ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/devfreq/governor_passive.c:235:9: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/devfreq/governor_passive.c:235:33: error: expected ';' before '{' token
     235 |         list_for_each_entry_safe(parent_cpu_data, &p_data->cpu_data_list, node) {
         |                                 ^                                               ~
         |                                 ;
   drivers/devfreq/governor_passive.c:225:34: warning: unused variable 'parent_cpu_data' [-Wunused-variable]
     225 |         struct devfreq_cpu_data *parent_cpu_data;
         |                                  ^~~~~~~~~~~~~~~
   drivers/devfreq/governor_passive.c:245:1: error: control reaches end of non-void function [-Werror=return-type]
     245 | }
         | ^
   cc1: some warnings being treated as errors


vim +/list_for_each_entry_safe +235 drivers/devfreq/governor_passive.c

   220	
   221	static int cpufreq_passive_unregister_notifier(struct devfreq *devfreq)
   222	{
   223		struct devfreq_passive_data *p_data
   224				= (struct devfreq_passive_data *)devfreq->data;
   225		struct devfreq_cpu_data *parent_cpu_data;
   226		int ret;
   227	
   228		if (p_data->nb.notifier_call) {
   229			ret = cpufreq_unregister_notifier(&p_data->nb,
   230						CPUFREQ_TRANSITION_NOTIFIER);
   231			if (ret < 0)
   232				return ret;
   233		}
   234	
 > 235		list_for_each_entry_safe(parent_cpu_data, &p_data->cpu_data_list, node) {
   236			list_del(&parent_cpu_data->node);
   237	
   238			if (parent_cpu_data->opp_table)
   239				dev_pm_opp_put_opp_table(parent_cpu_data->opp_table);
   240	
   241			kfree(parent_cpu_data);
   242		}
   243	
   244		return 0;
   245	}
   246	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp