From: Kechen Lu <kechenl@nvidia.com>
To: <kvm@vger.kernel.org>, <pbonzini@redhat.com>, <seanjc@google.com>
Cc: <vkuznets@redhat.com>, <somduttar@nvidia.com>,
<kechenl@nvidia.com>, <linux-kernel@vger.kernel.org>
Subject: [RFC PATCH v3 6/7] KVM: x86: Add a new guest_debug flag forcing exit to userspace
Date: Tue, 14 Jun 2022 18:16:21 -0700 [thread overview]
Message-ID: <20220615011622.136646-7-kechenl@nvidia.com> (raw)
In-Reply-To: <20220615011622.136646-1-kechenl@nvidia.com>
For debug and test purposes, there are needs to explicitly make
instruction triggered exits could be trapped to userspace. Simply
add a new flag for guest_debug interface could achieve this.
This patch also fills the userspace accessible field
vcpu->run->hw.hardware_exit_reason for userspace to determine the
original triggered VM-exits.
Signed-off-by: Kechen Lu <kechenl@nvidia.com>
---
arch/x86/kvm/svm/svm.c | 2 ++
arch/x86/kvm/vmx/vmx.c | 1 +
arch/x86/kvm/x86.c | 2 ++
include/uapi/linux/kvm.h | 1 +
tools/include/uapi/linux/kvm.h | 1 +
5 files changed, 7 insertions(+)
diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
index 7b3d64b3b901..e7ced6c3fbea 100644
--- a/arch/x86/kvm/svm/svm.c
+++ b/arch/x86/kvm/svm/svm.c
@@ -3259,6 +3259,8 @@ int svm_invoke_exit_handler(struct kvm_vcpu *vcpu, u64 exit_code)
if (!svm_check_exit_valid(exit_code))
return svm_handle_invalid_exit(vcpu, exit_code);
+ vcpu->run->hw.hardware_exit_reason = exit_code;
+
#ifdef CONFIG_RETPOLINE
if (exit_code == SVM_EXIT_MSR)
return msr_interception(vcpu);
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index 2d000638cc9b..c32c20c4aa4d 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -6151,6 +6151,7 @@ static int __vmx_handle_exit(struct kvm_vcpu *vcpu, fastpath_t exit_fastpath)
if (exit_reason.basic >= kvm_vmx_max_exit_handlers)
goto unexpected_vmexit;
+ vcpu->run->hw.hardware_exit_reason = exit_reason.basic;
#ifdef CONFIG_RETPOLINE
if (exit_reason.basic == EXIT_REASON_MSR_WRITE)
return kvm_emulate_wrmsr(vcpu);
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 8123309d097f..c6124a7e2180 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -8349,6 +8349,8 @@ int kvm_skip_emulated_instruction(struct kvm_vcpu *vcpu)
*/
if (unlikely(rflags & X86_EFLAGS_TF))
r = kvm_vcpu_do_singlestep(vcpu);
+ r &= !(vcpu->guest_debug & KVM_GUESTDBG_EXIT_USERSPACE);
+
return r;
}
EXPORT_SYMBOL_GPL(kvm_skip_emulated_instruction);
diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
index f2e76e436be5..23c335a6a285 100644
--- a/include/uapi/linux/kvm.h
+++ b/include/uapi/linux/kvm.h
@@ -777,6 +777,7 @@ struct kvm_s390_irq_state {
#define KVM_GUESTDBG_ENABLE 0x00000001
#define KVM_GUESTDBG_SINGLESTEP 0x00000002
+#define KVM_GUESTDBG_EXIT_USERSPACE 0x00000004
struct kvm_guest_debug {
__u32 control;
diff --git a/tools/include/uapi/linux/kvm.h b/tools/include/uapi/linux/kvm.h
index 6a184d260c7f..373b4a2b7fe9 100644
--- a/tools/include/uapi/linux/kvm.h
+++ b/tools/include/uapi/linux/kvm.h
@@ -773,6 +773,7 @@ struct kvm_s390_irq_state {
#define KVM_GUESTDBG_ENABLE 0x00000001
#define KVM_GUESTDBG_SINGLESTEP 0x00000002
+#define KVM_GUESTDBG_EXIT_USERSPACE 0x00000004
struct kvm_guest_debug {
__u32 control;
--
2.32.0
next prev parent reply other threads:[~2022-06-15 1:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 1:16 [RFC PATCH v3 0/7] KVM: x86: add per-vCPU exits disable capability Kechen Lu
2022-06-15 1:16 ` [RFC PATCH v3 1/7] KVM: x86: only allow exits disable before vCPUs created Kechen Lu
2022-07-20 17:12 ` Sean Christopherson
2022-07-20 17:49 ` Sean Christopherson
2022-07-20 18:38 ` Kechen Lu
2022-06-15 1:16 ` [RFC PATCH v3 2/7] KVM: x86: Move *_in_guest power management flags to vCPU scope Kechen Lu
2022-06-15 1:16 ` [RFC PATCH v3 3/7] KVM: x86: Reject disabling of MWAIT interception when not allowed Kechen Lu
2022-07-20 17:13 ` Sean Christopherson
2022-06-15 1:16 ` [RFC PATCH v3 4/7] KVM: x86: Let userspace re-enable previously disabled exits Kechen Lu
2022-06-15 2:51 ` Chao Gao
2022-07-20 17:18 ` Sean Christopherson
2022-06-15 1:16 ` [RFC PATCH v3 5/7] KVM: x86: add vCPU scoped toggling for " Kechen Lu
2022-06-15 2:43 ` Chao Gao
2022-06-16 3:04 ` Kechen Lu
2022-07-20 17:38 ` Sean Christopherson
2022-06-15 1:16 ` Kechen Lu [this message]
2022-06-15 1:16 ` [RFC PATCH v3 7/7] KVM: selftests: Add tests for VM and vCPU cap KVM_CAP_X86_DISABLE_EXITS Kechen Lu
2022-06-15 3:14 ` Chao Gao
2022-06-15 18:21 ` Kechen Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615011622.136646-7-kechenl@nvidia.com \
--to=kechenl@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=somduttar@nvidia.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox