Re: [PATCH 01/11] platform/chrome: cros_ec_proto: add "cros_ec_" prefix to send_command()

Guenter Roeck
2022-06-15T16:34:45Z

On Tue, Jun 14, 2022 at 10:13 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> To be neat, add "cros_ec_" prefix to static function send_command().
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>

Reviewed-by: Guenter Roeck <groeck@chromium.org>

> ---
> drivers/platform/chrome/cros_ec_proto.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
> index 6923ea4401e5..b02fd1414e52 100644
> --- a/drivers/platform/chrome/cros_ec_proto.c
> +++ b/drivers/platform/chrome/cros_ec_proto.c
> @@ -107,8 +107,7 @@ static int prepare_tx_legacy(struct cros_ec_device *ec_dev,
> return EC_MSG_TX_PROTO_BYTES + msg->outsize;
> }
>
> -static int send_command(struct cros_ec_device *ec_dev,
> - struct cros_ec_command *msg)
> +static int cros_ec_send_command(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)
> {
> int ret;
> int (*xfer_fxn)(struct cros_ec_device *ec, struct cros_ec_command *msg);
> @@ -255,7 +254,7 @@ static int cros_ec_get_host_event_wake_mask(struct cros_ec_device *ec_dev, uint3
> msg->command = EC_CMD_HOST_EVENT_GET_WAKE_MASK;
> msg->insize = sizeof(*r);
>
> - ret = send_command(ec_dev, msg);
> + ret = cros_ec_send_command(ec_dev, msg);
> if (ret < 0)
> goto exit;
>
> @@ -295,7 +294,7 @@ static int cros_ec_get_proto_info(struct cros_ec_device *ec_dev, int devidx)
> msg->command = EC_CMD_PASSTHRU_OFFSET(devidx) | EC_CMD_GET_PROTOCOL_INFO;
> msg->insize = sizeof(*info);
>
> - ret = send_command(ec_dev, msg);
> + ret = cros_ec_send_command(ec_dev, msg);
> /*
> * Send command once again when timeout occurred.
> * Fingerprint MCU (FPMCU) is restarted during system boot which
> @@ -304,7 +303,7 @@ static int cros_ec_get_proto_info(struct cros_ec_device *ec_dev, int devidx)
> * attempt because we waited at least EC_MSG_DEADLINE_MS.
> */
> if (ret == -ETIMEDOUT)
> - ret = send_command(ec_dev, msg);
> + ret = cros_ec_send_command(ec_dev, msg);
>
> if (ret < 0) {
> dev_dbg(ec_dev->dev,
> @@ -376,7 +375,7 @@ static int cros_ec_get_proto_info_legacy(struct cros_ec_device *ec_dev)
> params = (struct ec_params_hello *)msg->data;
> params->in_data = 0xa0b0c0d0;
>
> - ret = send_command(ec_dev, msg);
> + ret = cros_ec_send_command(ec_dev, msg);
> if (ret < 0) {
> dev_dbg(ec_dev->dev, "EC failed to respond to v2 hello: %d\n", ret);
> goto exit;
> @@ -453,7 +452,7 @@ static int cros_ec_get_host_command_version_mask(struct cros_ec_device *ec_dev,
> pver = (struct ec_params_get_cmd_versions *)msg->data;
> pver->cmd = cmd;
>
> - ret = send_command(ec_dev, msg);
> + ret = cros_ec_send_command(ec_dev, msg);
> if (ret < 0)
> goto exit;
>
> @@ -634,7 +633,7 @@ int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)
> }
> }
>
> - ret = send_command(ec_dev, msg);
> + ret = cros_ec_send_command(ec_dev, msg);
> mutex_unlock(&ec_dev->lock);
>
> return ret;
> --
> 2.36.1.476.g0c4daa206d-goog
>