From: Christoph Hellwig <hch@lst.de>
To: Erwan Velu <erwanaliasr1@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Erwan Velu <e.velu@criteo.com>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] nvme: Report model,sn,fw,pci device information during init
Date: Wed, 15 Jun 2022 12:53:16 +0200 [thread overview]
Message-ID: <20220615105316.GA7911@lst.de> (raw)
In-Reply-To: <CAL2JzuwnZhMgaVQ0=LAYfe6pWnxGLgR_b4xdF_==F3vL_Hh=gw@mail.gmail.com>
On Wed, Jun 15, 2022 at 09:57:05AM +0200, Erwan Velu wrote:
> > I would much prefer to not print it all. The Linux boot is way to spammy
> > to start with and this doesn't add any real value.
> >
>
> I know the boot is a bit spammy but when systems crash because of nvme
> drives, that's very handy to get a trace showing who was the culprit and
> what drive is installed (including the fw version which is usually a major
> source of troubles).
Well, usually they are all the same or a very small set of different
SKUs compared to the total number of drives.
next prev parent reply other threads:[~2022-06-15 10:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 21:09 [PATCH 1/2] nvme: Ensure char members of struct nvme_id_ctrl are null-terminated Erwan Velu
2022-06-14 21:09 ` [PATCH 2/2] nvme: Report model,sn,fw,pci device information during init Erwan Velu
2022-06-14 21:30 ` Keith Busch
2022-06-15 5:37 ` Christoph Hellwig
[not found] ` <CAL2JzuwnZhMgaVQ0=LAYfe6pWnxGLgR_b4xdF_==F3vL_Hh=gw@mail.gmail.com>
2022-06-15 10:53 ` Christoph Hellwig [this message]
2022-06-15 11:04 ` Jens Axboe
2022-06-14 21:24 ` [PATCH 1/2] nvme: Ensure char members of struct nvme_id_ctrl are null-terminated Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615105316.GA7911@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=e.velu@criteo.com \
--cc=erwanaliasr1@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox