From: Liang He <windhl@126.com>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
robh@kernel.org, frank.rowand@sony.com
Cc: windhl@126.com, linux-kernel@vger.kernel.org
Subject: [PATCH] arch: x86: kernel: Add missing of_node_put() in devicetree.c
Date: Wed, 15 Jun 2022 23:03:25 +0800 [thread overview]
Message-ID: <20220615150325.3969911-1-windhl@126.com> (raw)
In dtb_setup_hpet(), of_find_compatible_node() will return a node
pointer with refcount incremented. We should use of_node_put() when it
is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
arch/x86/kernel/devicetree.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
index 5cd51f25f446..6a386424ddf7 100644
--- a/arch/x86/kernel/devicetree.c
+++ b/arch/x86/kernel/devicetree.c
@@ -120,6 +120,9 @@ static void __init dtb_setup_hpet(void)
if (!dn)
return;
ret = of_address_to_resource(dn, 0, &r);
+
+ of_node_put(dn);
+
if (ret) {
WARN_ON(1);
return;
--
2.25.1
next reply other threads:[~2022-06-15 15:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 15:03 Liang He [this message]
2022-06-15 15:33 ` [PATCH] arch: x86: kernel: Add missing of_node_put() in devicetree.c Dave Hansen
2022-06-15 16:22 ` Rob Herring
2022-06-15 16:26 ` Rob Herring
2022-06-15 16:50 ` 和亮
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615150325.3969911-1-windhl@126.com \
--to=windhl@126.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=frank.rowand@sony.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox