Re: [PATCH] mm: cma: sync everything after EBUSY

kernel test robot
2022-06-15T19:35:38Z

Hi Edward,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on akpm-mm/mm-everything]

url: https://github.com/intel-lab-lkp/linux/commits/Edward-Wu/mm-cma-sync-everything-after-EBUSY/20220615-101716
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20220616/202206160330.nZiFjZFG-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/ef04552ed13eb371365fcc55c7ae1e5c3c211168
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Edward-Wu/mm-cma-sync-everything-after-EBUSY/20220615-101716
git checkout ef04552ed13eb371365fcc55c7ae1e5c3c211168
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> mm/cma.c:415:6: warning: no previous prototype for 'cma_sync_work' [-Wmissing-prototypes]
415 | void cma_sync_work(struct work_struct *work)
| ^~~~~~~~~~~~~
>> mm/cma.c:422:6: warning: no previous prototype for 'cma_ebusy_sync_pinned_pages' [-Wmissing-prototypes]
422 | void cma_ebusy_sync_pinned_pages(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/cma_sync_work +415 mm/cma.c

414
> 415 void cma_sync_work(struct work_struct *work)
416 {
417 ksys_sync();
418 kfree(work);
419 pr_debug("%s(): EBUSY Sync complete\n", __func__);
420 }
421
> 422 void cma_ebusy_sync_pinned_pages(void)
423 {
424 struct work_struct *work;
425
426 work = kmalloc(sizeof(*work), GFP_ATOMIC);
427 if (work) {
428 INIT_WORK(work, cma_sync_work);
429 schedule_work(work);
430 }
431 }
432

--
0-DAY CI Kernel Test Service