public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Liang He <windhl@126.com>,
	jonathanh@nvidia.com, mturquette@baylibre.com,
	pdeschrijver@nvidia.com, pgaikwad@nvidia.com,
	thierry.reding@gmail.com
Cc: linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org, windhl@126.com
Subject: Re: [PATCH v2] clk: tegra: (clk-tegra30) Add missing of_node_put()
Date: Wed, 15 Jun 2022 23:00:35 -0700	[thread overview]
Message-ID: <20220616060037.5AEB8C34114@smtp.kernel.org> (raw)
In-Reply-To: <20220616033622.3975621-1-windhl@126.com>

The subject should match historical subjects

 $ git log --oneline -3 -- drivers/clk/tegra/clk-tegra30.c

shows mostly "clk: tegra: ". Can you also combine this with the other
tegra patch? Don't think we need two patches for essentially the same
thing.

Quoting Liang He (2022-06-15 20:36:22)
> In tegra30_clock_init, of_find_matching_node() will return a node
> pointer with refcount incremented. We should use of_node_put() when
> the node pointer is not used anymore.
> 
> Signed-off-by: Liang He <windhl@126.com>
> ---
>  changelog:
> 
>  v2: use real name for Sob

Thanks!

>  v1: fix missing bug

  reply	other threads:[~2022-06-16  6:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16  3:36 [PATCH v2] clk: tegra: (clk-tegra30) Add missing of_node_put() Liang He
2022-06-16  6:00 ` Stephen Boyd [this message]
2022-06-16  8:19   ` Liang He
2022-06-16  8:42     ` Conor.Dooley
2022-06-16  9:09       ` Liang He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220616060037.5AEB8C34114@smtp.kernel.org \
    --to=sboyd@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=windhl@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox