public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: menglong8.dong@gmail.com
To: edumazet@google.com
Cc: rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net,
	yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, imagedong@tencent.com, kafai@fb.com,
	talalahmad@google.com, keescook@chromium.org,
	dongli.zhang@oracle.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: [PATCH net-next v4 1/8] net: skb: use SKB_NOT_DROPPED in kfree_skb_reason() as consume_skb()
Date: Fri, 17 Jun 2022 18:05:07 +0800	[thread overview]
Message-ID: <20220617100514.7230-2-imagedong@tencent.com> (raw)
In-Reply-To: <20220617100514.7230-1-imagedong@tencent.com>

From: Menglong Dong <imagedong@tencent.com>

Inorder to simply the code, allow SKB_NOT_DROPPED to be passed to
kfree_skb_reason(), suggested by Eric. Therefore, consume_skb(skb) can
be replaced with kfree_skb_reason(skb, SKB_NOT_DROPPED).

Not sure if it is suitable to make consume_skb() a simple call to
kfree_skb_reason(skb, SKB_NOT_DROPPED), as this can increase the
function call chain.

Signed-off-by: Menglong Dong <imagedong@tencent.com>
---
 net/core/skbuff.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index b661040c100e..92f01b59ae40 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -769,15 +769,22 @@ EXPORT_SYMBOL(__kfree_skb);
  *	Drop a reference to the buffer and free it if the usage count has
  *	hit zero. Meanwhile, pass the drop reason to 'kfree_skb'
  *	tracepoint.
+ *
+ *	When the reason is SKB_NOT_DROPPED, it means that the packet is
+ *	freed normally, and the event 'consume_skb' will be triggered.
  */
 void kfree_skb_reason(struct sk_buff *skb, enum skb_drop_reason reason)
 {
 	if (!skb_unref(skb))
 		return;
 
-	DEBUG_NET_WARN_ON_ONCE(reason <= 0 || reason >= SKB_DROP_REASON_MAX);
+	DEBUG_NET_WARN_ON_ONCE(reason < 0 || reason >= SKB_DROP_REASON_MAX);
+
+	if (reason)
+		trace_kfree_skb(skb, __builtin_return_address(0), reason);
+	else
+		trace_consume_skb(skb);
 
-	trace_kfree_skb(skb, __builtin_return_address(0), reason);
 	__kfree_skb(skb);
 }
 EXPORT_SYMBOL(kfree_skb_reason);
-- 
2.36.1


  reply	other threads:[~2022-06-17 10:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17 10:05 [PATCH net-next v4 0/8] net: tcp: add skb drop reasons to tcp state change menglong8.dong
2022-06-17 10:05 ` menglong8.dong [this message]
2022-06-17 10:05 ` [PATCH net-next v4 2/8] net: skb: introduce __skb_queue_purge_reason() menglong8.dong
2022-06-17 10:05 ` [PATCH net-next v4 3/8] net: sock: introduce sk_stream_kill_queues_reason() menglong8.dong
2022-06-17 10:05 ` [PATCH net-next v4 4/8] net: inet: add skb drop reason to inet_csk_destroy_sock() menglong8.dong
2022-06-17 10:05 ` [PATCH net-next v4 5/8] net: tcp: add skb drop reasons to tcp connect requesting menglong8.dong
2022-06-17 10:05 ` [PATCH net-next v4 6/8] net: tcp: add skb drop reasons to tcp tw code path menglong8.dong
2022-06-17 10:05 ` [PATCH net-next v4 7/8] net: tcp: add skb drop reasons to route_req() menglong8.dong
2022-06-17 10:05 ` [PATCH net-next v4 8/8] net: tcp: use LINUX_MIB_TCPABORTONLINGER in tcp_rcv_state_process() menglong8.dong
2022-06-18  3:05 ` [PATCH net-next v4 0/8] net: tcp: add skb drop reasons to tcp state change Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220617100514.7230-2-imagedong@tencent.com \
    --to=menglong8.dong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dongli.zhang@oracle.com \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=imagedong@tencent.com \
    --cc=kafai@fb.com \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=talalahmad@google.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox