public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Max Staudt <max@enpas.org>,
	Wolfgang Grandegger <wg@grandegger.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>
Cc: kbuild-all@lists.01.org, linux-can@vger.kernel.org,
	Vincent Mailhol <vincent.mailhol@gmail.com>,
	Oliver Neukum <oneukum@suse.com>,
	linux-kernel@vger.kernel.org, Max Staudt <max@enpas.org>
Subject: Re: [PATCH v9] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters
Date: Sun, 19 Jun 2022 06:02:32 +0800	[thread overview]
Message-ID: <202206190533.0uzpvGYN-lkp@intel.com> (raw)
In-Reply-To: <20220618195031.10975-1-max@enpas.org>

Hi Max,

I love your patch! Yet something to improve:

[auto build test ERROR on mkl-can-next/testing]
[also build test ERROR on linus/master v5.19-rc2 next-20220617]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Max-Staudt/can-tty-can327-CAN-ldisc-driver-for-ELM327-based-OBD-II-adapters/20220619-035333
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220619/202206190533.0uzpvGYN-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/2338446348d90b3793e53238f210299f13bf6ec4
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Max-Staudt/can-tty-can327-CAN-ldisc-driver-for-ELM327-based-OBD-II-adapters/20220619-035333
        git checkout 2338446348d90b3793e53238f210299f13bf6ec4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/net/can/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/net/can/can327.c:1104:27: error: 'N_CAN327' undeclared here (not in a function)
    1104 |         .num            = N_CAN327,
         |                           ^~~~~~~~


vim +/N_CAN327 +1104 drivers/net/can/can327.c

  1100	
  1101	static struct tty_ldisc_ops can327_ldisc = {
  1102		.owner		= THIS_MODULE,
  1103		.name		= "can327",
> 1104		.num		= N_CAN327,
  1105		.receive_buf	= can327_ldisc_rx,
  1106		.write_wakeup	= can327_ldisc_tx_wakeup,
  1107		.open		= can327_ldisc_open,
  1108		.close		= can327_ldisc_close,
  1109		.ioctl		= can327_ldisc_ioctl,
  1110	};
  1111	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

  reply	other threads:[~2022-06-18 22:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-18 19:50 [PATCH v9] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters Max Staudt
2022-06-18 22:02 ` kernel test robot [this message]
2022-06-19  8:08   ` Marc Kleine-Budde
2022-06-27 15:05 ` Marc Kleine-Budde
2022-06-27 17:01   ` Max Staudt
2022-07-05  9:43     ` Geert Uytterhoeven
2022-07-05  9:49       ` Marc Kleine-Budde
2022-07-05  9:56         ` Max Staudt
2022-07-05 10:16           ` Geert Uytterhoeven
2022-07-05 10:39             ` Max Staudt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202206190533.0uzpvGYN-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max@enpas.org \
    --cc=mkl@pengutronix.de \
    --cc=oneukum@suse.com \
    --cc=vincent.mailhol@gmail.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox