From: Jakub Kicinski <kuba@kernel.org>
To: wuchi <wuchi.zero@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net, lib/once: Remove {net_}get_random_once_wait macro
Date: Sun, 19 Jun 2022 15:42:47 -0700 [thread overview]
Message-ID: <20220619154247.038d66f8@kernel.org> (raw)
In-Reply-To: <20220619074641.40916-1-wuchi.zero@gmail.com>
On Sun, 19 Jun 2022 15:46:41 +0800 wuchi wrote:
> DO_ONCE(func, ...) will call func with spinlock which acquired by
> spin_lock_irqsave in __do_once_start. But the get_random_once_wait
> will sleep in get_random_bytes_wait -> wait_for_random_bytes.
>
> Fortunately, there is no place to use {net_}get_random_once_wait,
> so we could remove them simply.
>
> Signed-off-by: wuchi <wuchi.zero@gmail.com>
Yeah, sure, if it builds:
Acked-by: Jakub Kicinski <kuba@kernel.org>
If Andrew doesn't pick it you please repost CCing netdev.
prev parent reply other threads:[~2022-06-19 22:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-19 7:46 [PATCH] net, lib/once: Remove {net_}get_random_once_wait macro wuchi
2022-06-19 22:42 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220619154247.038d66f8@kernel.org \
--to=kuba@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wuchi.zero@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox