From: Jason Wang <jasowang@redhat.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
mst@redhat.com, jasowang@redhat.com
Cc: davem@davemloft.net, kuba@kernel.org, erwan.yvin@stericsson.com
Subject: [PATCH 1/3] caif_virtio: remove virtqueue_disable_cb() in probe
Date: Mon, 20 Jun 2022 13:11:13 +0800 [thread overview]
Message-ID: <20220620051115.3142-2-jasowang@redhat.com> (raw)
In-Reply-To: <20220620051115.3142-1-jasowang@redhat.com>
This disabling is a just a hint with best effort, there's no guarantee
that device doesn't send notification. The driver should survive with
that, so let's remove it.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/net/caif/caif_virtio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c
index 5458f57177a0..c677ded81133 100644
--- a/drivers/net/caif/caif_virtio.c
+++ b/drivers/net/caif/caif_virtio.c
@@ -705,9 +705,6 @@ static int cfv_probe(struct virtio_device *vdev)
netdev->needed_headroom = cfv->tx_hr;
netdev->needed_tailroom = cfv->tx_tr;
- /* Disable buffer release interrupts unless we have stopped TX queues */
- virtqueue_disable_cb(cfv->vq_tx);
-
netdev->mtu = cfv->mtu - cfv->tx_tr;
vdev->priv = cfv;
--
2.25.1
next prev parent reply other threads:[~2022-06-20 5:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 5:11 [PATCH 0/3] Fixing races in probe/remove Jason Wang
2022-06-20 5:11 ` Jason Wang [this message]
2022-06-20 9:02 ` [PATCH 1/3] caif_virtio: remove virtqueue_disable_cb() in probe Michael S. Tsirkin
2022-06-21 3:10 ` Jason Wang
2022-06-20 5:11 ` [PATCH 2/3] caif_virtio: fix the race between virtio_device_ready() and ndo_open() Jason Wang
2022-06-20 9:04 ` Michael S. Tsirkin
2022-06-20 5:11 ` [PATCH 3/3] caif_virtio: fix the race between reset and netdev unregister Jason Wang
2022-06-20 9:09 ` Michael S. Tsirkin
2022-06-20 9:18 ` Jason Wang
2022-06-20 10:18 ` Michael S. Tsirkin
2022-06-21 3:09 ` Jason Wang
2022-06-21 6:00 ` Michael S. Tsirkin
2022-06-21 6:25 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620051115.3142-2-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=erwan.yvin@stericsson.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox