From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D89DC43334 for ; Mon, 20 Jun 2022 10:39:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240963AbiFTKja (ORCPT ); Mon, 20 Jun 2022 06:39:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240310AbiFTKjX (ORCPT ); Mon, 20 Jun 2022 06:39:23 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 885D31400F for ; Mon, 20 Jun 2022 03:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655721562; x=1687257562; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=4Twk46FsDuF77SRth9P1/m8cJs6aDI8dgjNxONIBlVI=; b=cdIdtZiA84xDHhDkPoqXMLDtsQm5E+nnfB0PZF0BlXhckSOplLwfKjOV pjyDo7wdqr4CXxMjfA0etNoEYCkiYaNE3PA52SYFAdqdzfGCO0FrEuCga 4fgvDDLMK9t8Ufpyp6wXV+4oTmfoM9hvAit84HXUWQRgP/xaBHLAaNMUp 9CVTji4rBe8easnZD0mHSfShOvi1qiCI703WPrp9eLLMigkeq5Op5T4rb y7I5MIqLrhOUPcmScz4nW91gFIfTroo9Db5tsn+yxxIIcw4VMMGb02sJP ByoB/H5czQg3JrilYKDatXzCTU1lPCICCX95Qodb1wRuX61q1mALemQ5a w==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="262896713" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="262896713" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2022 03:39:22 -0700 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="643056788" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO ahunter-VirtualBox.home\044ger.corp.intel.com) ([10.252.58.69]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2022 03:39:20 -0700 From: Adrian Hunter To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , linux-kernel@vger.kernel.org Subject: [PATCH] perf inject: Fix missing free in copy_kcore_dir() Date: Mon, 20 Jun 2022 13:39:04 +0300 Message-Id: <20220620103904.7960-1-adrian.hunter@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Free string allocated by asprintf(). Fixes: d8fc08550929bb ("perf inject: Keep a copy of kcore_dir") Signed-off-by: Adrian Hunter --- tools/perf/builtin-inject.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c index 42e2918fd1cc..fee9da14afc6 100644 --- a/tools/perf/builtin-inject.c +++ b/tools/perf/builtin-inject.c @@ -891,7 +891,9 @@ static int copy_kcore_dir(struct perf_inject *inject) if (ret < 0) return ret; pr_debug("%s\n", cmd); - return system(cmd); + ret = system(cmd); + free(cmd); + return ret; } static int output_fd(struct perf_inject *inject) -- 2.25.1