From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9361BCCA491 for ; Mon, 20 Jun 2022 13:14:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345680AbiFTNOo (ORCPT ); Mon, 20 Jun 2022 09:14:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344203AbiFTNKB (ORCPT ); Mon, 20 Jun 2022 09:10:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 047CC1C90C for ; Mon, 20 Jun 2022 06:05:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 344F161531 for ; Mon, 20 Jun 2022 13:04:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE253C385A2; Mon, 20 Jun 2022 13:04:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655730285; bh=XrEBOe9xjcJ/LnVKgGjK9+wCo3I/byuEwEXiFATHKAo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OKaBPRsy8/Ki7ltaoJSLt0bYTQBfRMaLgY+rk5Mf7uFx67N2jvXTGRhsnoJHYTCbt 0SS1osABRjzr/ngGS8TFUikjozkiUQGAWl3yJ6Uf4+GDlURQQXh2ZhtVGUnRsmiWg3 ooGNWDcPOgGYW6pZRXLAvv+UHqiWWDjs+HSrs6+wrKyxWfT7Mkp2+xObo6TspsJF+B kCdM2r2NqIFdfH1Baeo2+Inwtcu9lB+Oq7IFNNTp5VXIMMGC8xF7ygwClG5/ec/rdx RPbTYuE1CkKcjEhKZrns/bFw6UdlrIZ+y0yIky8wK8Of0vlzU43Jgny9/sjs7apgOC GwUj2LDXYKlpQ== From: Oded Gabbay To: linux-kernel@vger.kernel.org Cc: Dani Liberman Subject: [PATCH 06/17] habanalabs: avoid unnecessary error print Date: Mon, 20 Jun 2022 16:04:21 +0300 Message-Id: <20220620130432.1180451-6-ogabbay@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220620130432.1180451-1-ogabbay@kernel.org> References: <20220620130432.1180451-1-ogabbay@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dani Liberman When sending a packet to FW right after it made reset, we will get packet timeout. Since it is expected behavior, we don't need to print an error in such case. Hence, when driver is in hard reset it will avoid from printing error messages about packet timeout. Signed-off-by: Dani Liberman Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/firmware_if.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/common/firmware_if.c b/drivers/misc/habanalabs/common/firmware_if.c index 828a36af5b14..bd66e4f84156 100644 --- a/drivers/misc/habanalabs/common/firmware_if.c +++ b/drivers/misc/habanalabs/common/firmware_if.c @@ -267,7 +267,14 @@ int hl_fw_send_cpu_message(struct hl_device *hdev, u32 hw_queue_id, u32 *msg, hl_hw_queue_inc_ci_kernel(hdev, hw_queue_id); if (rc == -ETIMEDOUT) { - dev_err(hdev->dev, "Device CPU packet timeout (0x%x)\n", tmp); + /* If FW performed reset just before sending it a packet, we will get a timeout. + * This is expected behavior, hence no need for error message. + */ + if (!hl_device_operational(hdev, NULL) && !hdev->reset_info.is_in_soft_reset) + dev_dbg(hdev->dev, "Device CPU packet timeout (0x%x) due to FW reset\n", + tmp); + else + dev_err(hdev->dev, "Device CPU packet timeout (0x%x)\n", tmp); hdev->device_cpu_disabled = true; goto out; } -- 2.25.1