From: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
To: <miquel.raynal@bootlin.com>, <vigneshr@ti.com>
Cc: <git@amd.com>, <boris.brezillon@collabora.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<amit.kumar-mahapatra@amd.com>, <akumarma@amd.com>,
Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Subject: [PATCH v2 1/2] mtd: rawnand: arasan: Update NAND bus clock instead of system clock
Date: Tue, 21 Jun 2022 14:24:59 +0530 [thread overview]
Message-ID: <20220621085500.1005-2-amit.kumar-mahapatra@xilinx.com> (raw)
In-Reply-To: <20220621085500.1005-1-amit.kumar-mahapatra@xilinx.com>
In current implementation the Arasan NAND driver is updating the
system clock(i.e., anand->clk) in accordance to the timing modes
(i.e., SDR or NVDDR). But as per the Arasan NAND controller spec the
flash clock or the NAND bus clock(i.e., nfc->bus_clk), need to be
updated instead. This patch keeps the system clock unchanged and updates
the NAND bus clock as per the timing modes.
Fixes: 197b88fecc50 ("mtd: rawnand: arasan: Add new Arasan NAND controller")
Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
---
drivers/mtd/nand/raw/arasan-nand-controller.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/arasan-nand-controller.c b/drivers/mtd/nand/raw/arasan-nand-controller.c
index 53bd10738418..4f6da82dd2b1 100644
--- a/drivers/mtd/nand/raw/arasan-nand-controller.c
+++ b/drivers/mtd/nand/raw/arasan-nand-controller.c
@@ -968,6 +968,7 @@ static int anfc_setup_interface(struct nand_chip *chip, int target,
const struct nand_sdr_timings *sdr;
const struct nand_nvddr_timings *nvddr;
unsigned int tccs_min, dqs_mode, fast_tcad;
+ int ret;
if (nand_interface_is_nvddr(conf)) {
nvddr = nand_get_nvddr_timings(conf);
@@ -1043,7 +1044,11 @@ static int anfc_setup_interface(struct nand_chip *chip, int target,
DQS_BUFF_SEL_OUT(dqs_mode);
}
- anand->clk = ANFC_XLNX_SDR_DFLT_CORE_CLK;
+ ret = clk_set_rate(nfc->bus_clk, ANFC_XLNX_SDR_DFLT_CORE_CLK);
+ if (ret) {
+ dev_err(nfc->dev, "Failed to change bus clock rate\n");
+ return ret;
+ }
/*
* Due to a hardware bug in the ZynqMP SoC, SDR timing modes 0-1 work
@@ -1052,8 +1057,13 @@ static int anfc_setup_interface(struct nand_chip *chip, int target,
* 80MHz when using SDR modes 2-5 with this SoC.
*/
if (of_device_is_compatible(np, "xlnx,zynqmp-nand-controller") &&
- nand_interface_is_sdr(conf) && conf->timings.mode >= 2)
- anand->clk = ANFC_XLNX_SDR_HS_CORE_CLK;
+ nand_interface_is_sdr(conf) && conf->timings.mode >= 2) {
+ ret = clk_set_rate(nfc->bus_clk, ANFC_XLNX_SDR_HS_CORE_CLK);
+ if (ret) {
+ dev_err(nfc->dev, "Failed to change bus clock rate\n");
+ return ret;
+ }
+ }
return 0;
}
--
2.17.1
next prev parent reply other threads:[~2022-06-21 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 8:54 [PATCH v2 0/2] mtd: rawnand: arasan: Fix clock rate in NV-DDR Amit Kumar Mahapatra
2022-06-21 8:54 ` Amit Kumar Mahapatra [this message]
2022-06-24 18:45 ` [PATCH v2 1/2] mtd: rawnand: arasan: Update NAND bus clock instead of system clock Miquel Raynal
2022-06-27 16:23 ` Mahapatra, Amit Kumar
2022-06-21 8:55 ` [PATCH v2 2/2] mtd: rawnand: arasan: Fix clock rate in NV-DDR Amit Kumar Mahapatra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621085500.1005-2-amit.kumar-mahapatra@xilinx.com \
--to=amit.kumar-mahapatra@xilinx.com \
--cc=akumarma@amd.com \
--cc=amit.kumar-mahapatra@amd.com \
--cc=boris.brezillon@collabora.com \
--cc=git@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox