From: Manivannan Sadhasivam <mani@kernel.org>
To: Slark Xiao <slark_xiao@163.com>
Cc: quic_hemantk@quicinc.com, gregkh@linuxfoundation.org,
loic.poulain@linaro.org, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
christophe.jaillet@wanadoo.fr
Subject: Re: [PATCH] bus: mhi: host: Add support for Cinterion MV31-W with new device ID
Date: Tue, 21 Jun 2022 18:47:51 +0530 [thread overview]
Message-ID: <20220621131751.GD17181@thinkpad> (raw)
In-Reply-To: <20220601061915.10946-1-slark_xiao@163.com>
On Wed, Jun 01, 2022 at 02:19:15PM +0800, Slark Xiao wrote:
Please use pci_generic in the subject as this change belongs to that driver:
bus: mhi: host: pci_generic: Add Cinterion MV31-W with new baseline
> As Thales would use a new baseline, so we need to add
> a new device ID to separate it from previous.
>
Thales refers to Cinterion MV31-W, right? Better just use Cinterion MV31-W.
Like,
Cinterion MV31-W modem with a new baseline (firmware) is sold as a separate
product with different device ID. So add support for the same reusing the
config.
Thanks,
Mani
> Signed-off-by: Slark Xiao <slark_xiao@163.com>
> ---
> drivers/bus/mhi/host/pci_generic.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 6fbc5915ea36..a2a4fd2cd13d 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -578,6 +578,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> /* MV31-W (Cinterion) */
> { PCI_DEVICE(0x1269, 0x00b3),
> .driver_data = (kernel_ulong_t) &mhi_mv31_info },
> + /* MV31-W (Cinterion), based on new baseline */
> + { PCI_DEVICE(0x1269, 0x00b4),
> + .driver_data = (kernel_ulong_t) &mhi_mv31_info },
> /* MV32-WA (Cinterion) */
> { PCI_DEVICE(0x1269, 0x00ba),
> .driver_data = (kernel_ulong_t) &mhi_mv32_info },
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-06-21 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 6:19 [PATCH] bus: mhi: host: Add support for Cinterion MV31-W with new device ID Slark Xiao
2022-06-21 13:17 ` Manivannan Sadhasivam [this message]
2022-06-22 3:11 ` Slark Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621131751.GD17181@thinkpad \
--to=mani@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=quic_hemantk@quicinc.com \
--cc=slark_xiao@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox