From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF84C433EF for ; Tue, 21 Jun 2022 21:00:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355577AbiFUVAy (ORCPT ); Tue, 21 Jun 2022 17:00:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355489AbiFUU6b (ORCPT ); Tue, 21 Jun 2022 16:58:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9090B326C2; Tue, 21 Jun 2022 13:51:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 71AC761892; Tue, 21 Jun 2022 20:51:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2705DC341C5; Tue, 21 Jun 2022 20:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655844670; bh=lfZC+lVFAvSXtJSVdmb9j6eQHqF28S1Poh+pDUdcEYA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ww/fKWeFVcUG6w5mq46lQ0oNL2+hGFdDW0lDvLRmuWUB8D5756F4Pkm5A7oP5lbjM Evz5N2g9vbv0+SRkyyCcRKsGU4LbC+c97UoFesVS7NR96CmHNtBRYL1Ts9lJpsW+xd Hrx0FQy6kEY8wbN1oFBXkSa59AaO6cZIXgsvGtm4md7YWkGg6btcnFM0fZAiicMnM+ H08cCDhWU/I7RqAGrvd9bbaf40Juc7XX9BOeXNcymGRatVzcAEX+TgQFJYAD8z1LKk zN/unms1g5uYV0dCEVgZEDDMHwyQeYytawgFquwKZQJ1UUFU4LqbbY36zNSMAw7/ux yecJiRJhGcYmg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Keith Busch , Chaitanya Kulkarni , Christoph Hellwig , Sasha Levin , axboe@fb.com, sagi@grimberg.me, linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 5.10 04/11] nvme-pci: add trouble shooting steps for timeouts Date: Tue, 21 Jun 2022 16:50:58 -0400 Message-Id: <20220621205105.250640-4-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220621205105.250640-1-sashal@kernel.org> References: <20220621205105.250640-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Keith Busch [ Upstream commit 4641a8e6e145f595059e695f0f8dbbe608134086 ] Many users have encountered IO timeouts with a CSTS value of 0xffffffff, which indicates a failure to read the register. While there are various potential causes for this observation, faulty NVMe APST has been the culprit quite frequently. Add the recommended troubleshooting steps in the error output when this condition occurs. Signed-off-by: Keith Busch Reviewed-by: Chaitanya Kulkarni Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- drivers/nvme/host/pci.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 7de24a10dd92..26f451b70511 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -1252,6 +1252,14 @@ static void nvme_warn_reset(struct nvme_dev *dev, u32 csts) dev_warn(dev->ctrl.device, "controller is down; will reset: CSTS=0x%x, PCI_STATUS read failed (%d)\n", csts, result); + + if (csts != ~0) + return; + + dev_warn(dev->ctrl.device, + "Does your device have a faulty power saving mode enabled?\n"); + dev_warn(dev->ctrl.device, + "Try \"nvme_core.default_ps_max_latency_us=0 pcie_aspm=off\" and report a bug\n"); } static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved) -- 2.35.1