From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEF8BC43334 for ; Tue, 21 Jun 2022 21:02:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355829AbiFUVCB (ORCPT ); Tue, 21 Jun 2022 17:02:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355699AbiFUU6x (ORCPT ); Tue, 21 Jun 2022 16:58:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9127A32ED3; Tue, 21 Jun 2022 13:51:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0F59CB81B2F; Tue, 21 Jun 2022 20:51:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A5A9C385A2; Tue, 21 Jun 2022 20:51:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655844695; bh=dA8eO3kJ42RFGQFpPPCVUellUtKHSutFT3VRfj0OK3Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jr1AdTHsJn6nEz99XerquZB+35OAWxs65emNEe7EYr4BjADn6y5rvg85Q2XmanKK2 +reeh+rLprVF5RvFoX9P77grfvxE3B4RfU1sD3KCOAiAO1Qq0gT7kraoFqY9hGFFmq V8wQMZH4KpPu+fF2Y6r9rKdsvbHNiKnvYjFIXyPc3n6E8VeFt48X12HqHVuz/xu+xZ cuDNEZMugWOQVFOim7TFck3rzHr+KLSkrF7IygZw8Kiv8f7vuRo4dtV39aGGTQBgrA /GUFU9nqxvfjYdxb7Cdcn4EYLzqspE/Lt7icuFDda/ZM2hIc99LDwumPkqmT7yFTNX a1tBU2rxHRn5w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Keith Busch , Chaitanya Kulkarni , Christoph Hellwig , Sasha Levin , axboe@fb.com, sagi@grimberg.me, linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 4/7] nvme-pci: add trouble shooting steps for timeouts Date: Tue, 21 Jun 2022 16:51:26 -0400 Message-Id: <20220621205130.250874-4-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220621205130.250874-1-sashal@kernel.org> References: <20220621205130.250874-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Keith Busch [ Upstream commit 4641a8e6e145f595059e695f0f8dbbe608134086 ] Many users have encountered IO timeouts with a CSTS value of 0xffffffff, which indicates a failure to read the register. While there are various potential causes for this observation, faulty NVMe APST has been the culprit quite frequently. Add the recommended troubleshooting steps in the error output when this condition occurs. Signed-off-by: Keith Busch Reviewed-by: Chaitanya Kulkarni Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- drivers/nvme/host/pci.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index b06d2b6bd3fe..f9fd62b894dc 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -1138,6 +1138,14 @@ static void nvme_warn_reset(struct nvme_dev *dev, u32 csts) dev_warn(dev->ctrl.device, "controller is down; will reset: CSTS=0x%x, PCI_STATUS read failed (%d)\n", csts, result); + + if (csts != ~0) + return; + + dev_warn(dev->ctrl.device, + "Does your device have a faulty power saving mode enabled?\n"); + dev_warn(dev->ctrl.device, + "Try \"nvme_core.default_ps_max_latency_us=0 pcie_aspm=off\" and report a bug\n"); } static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved) -- 2.35.1