From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BE11C43334 for ; Wed, 22 Jun 2022 11:17:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357316AbiFVLRA (ORCPT ); Wed, 22 Jun 2022 07:17:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357194AbiFVLQx (ORCPT ); Wed, 22 Jun 2022 07:16:53 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F733C4AE; Wed, 22 Jun 2022 04:16:47 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id DB13D68AA6; Wed, 22 Jun 2022 13:16:41 +0200 (CEST) Date: Wed, 22 Jun 2022 13:16:41 +0200 From: Christoph Hellwig To: Serge Semin Cc: Serge Semin , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Vladimir Murzin , Alexey Malahov , Pavel Parkhomenko , Manivannan Sadhasivam , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , linux-arm-kernel@lists.infradead.org, Srujana Challa , Arnaud Ebalard , Boris Brezillon , linux-crypto@vger.kernel.org, Vinod Koul , dmaengine@vger.kernel.org, Shawn Guo , Sascha Hauer , Li Yang , Geert Uytterhoeven , Magnus Damm , linux-renesas-soc@vger.kernel.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , David Airlie , Gerd Hoffmann , Tomasz Figa , Oded Gabbay , Arnd Bergmann , Greg Kroah-Hartman , Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, Sunil Goutham , Linu Cherian , Geetha sowjanya , Jon Mason , Dave Jiang , ntb@lists.linux.dev, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma-direct: take dma-ranges/offsets into account in resource mapping Message-ID: <20220622111641.GA27618@lst.de> References: <20220610080802.11147-1-Sergey.Semin@baikalelectronics.ru> <20220620213755.kczuriyildoublzi@mobilestation> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220620213755.kczuriyildoublzi@mobilestation> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'd really like to hear something from the driver maintainers. The cod change itself looks fine, we just need to make sure it does not break any driver assumptions. And I think at least for the PCIe P2P and NTB cases I fear it might break them. The proper logic for those is in the p2p helpers, but it seems like not everyone is using them.