linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 0/3] Staging: rtl8192e: Safer allocation and cleaner error handling
@ 2022-06-23 10:05 Felix Schlepper
  2022-06-23 10:22 ` Dan Carpenter
  2022-06-23 10:47 ` Greg KH
  0 siblings, 2 replies; 5+ messages in thread
From: Felix Schlepper @ 2022-06-23 10:05 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Felix Schlepper


v2:
  - replaced kmalloc with kzalloc against memory initialization defects,
    thus also removing a memset
  - made error handling more consistent

v3:
  - Split into smaller commits so that it's easier to review

v4:
  - clearer commit messages
  - added missing kfree

Felix Schlepper (3):
  Staging: rtl8192e: Use struct_size
  Staging: rtl8192e: Using kzalloc and delete memset
  Staging: rtl8192e: Cleaning up error handling

 drivers/staging/rtl8192e/rtllib_tx.c | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

--
2.36.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v4 0/3] Staging: rtl8192e: Safer allocation and cleaner error handling
  2022-06-23 10:05 [PATCH v4 0/3] Staging: rtl8192e: Safer allocation and cleaner error handling Felix Schlepper
@ 2022-06-23 10:22 ` Dan Carpenter
  2022-06-23 10:47 ` Greg KH
  1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2022-06-23 10:22 UTC (permalink / raw)
  To: Felix Schlepper; +Cc: gregkh, linux-staging, linux-kernel

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v4 0/3] Staging: rtl8192e: Safer allocation and cleaner error handling
  2022-06-23 10:05 [PATCH v4 0/3] Staging: rtl8192e: Safer allocation and cleaner error handling Felix Schlepper
  2022-06-23 10:22 ` Dan Carpenter
@ 2022-06-23 10:47 ` Greg KH
  2022-06-23 13:38   ` Felix Schlepper
  1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2022-06-23 10:47 UTC (permalink / raw)
  To: Felix Schlepper; +Cc: linux-staging, linux-kernel

On Thu, Jun 23, 2022 at 12:05:54PM +0200, Felix Schlepper wrote:
> 
> v2:
>   - replaced kmalloc with kzalloc against memory initialization defects,
>     thus also removing a memset
>   - made error handling more consistent
> 
> v3:
>   - Split into smaller commits so that it's easier to review
> 
> v4:
>   - clearer commit messages
>   - added missing kfree
> 
> Felix Schlepper (3):
>   Staging: rtl8192e: Use struct_size
>   Staging: rtl8192e: Using kzalloc and delete memset
>   Staging: rtl8192e: Cleaning up error handling
> 
>  drivers/staging/rtl8192e/rtllib_tx.c | 24 +++++++++++-------------
>  1 file changed, 11 insertions(+), 13 deletions(-)
> 
> --
> 2.36.1
> 

Why is this not properly threaded with the patches itself?  Please
resend so that our tools will pick them all up correctly.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v4 0/3] Staging: rtl8192e: Safer allocation and cleaner error handling
  2022-06-23 10:47 ` Greg KH
@ 2022-06-23 13:38   ` Felix Schlepper
  0 siblings, 0 replies; 5+ messages in thread
From: Felix Schlepper @ 2022-06-23 13:38 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-staging, linux-kernel

On 23.06.2022 12:47, Greg KH wrote:
> On Thu, Jun 23, 2022 at 12:05:54PM +0200, Felix Schlepper wrote:
> >
> > v2:
> >   - replaced kmalloc with kzalloc against memory initialization defects,
> >     thus also removing a memset
> >   - made error handling more consistent
> >
> > v3:
> >   - Split into smaller commits so that it's easier to review
> >
> > v4:
> >   - clearer commit messages
> >   - added missing kfree
> >
> > Felix Schlepper (3):
> >   Staging: rtl8192e: Use struct_size
> >   Staging: rtl8192e: Using kzalloc and delete memset
> >   Staging: rtl8192e: Cleaning up error handling
> >
> >  drivers/staging/rtl8192e/rtllib_tx.c | 24 +++++++++++-------------
> >  1 file changed, 11 insertions(+), 13 deletions(-)
> >
> > --
> > 2.36.1
> >
>
> Why is this not properly threaded with the patches itself?  Please
> resend so that our tools will pick them all up correctly.
>
> thanks,
>
> greg k-h
I am trying... I thought I figured it out with the help of kernelnewbies
irc, but I resend and it is still not threaded properly.
I tried to reply to the message-id with the patchseries,which worked
locally, but I am just
causing a mess on the mailing list at this point. Will try to figure
this out properly.

Cheers
Felix Schlepper

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v4 0/3] Staging: rtl8192e: Safer allocation and cleaner error handling
@ 2022-06-23 20:27 Felix Schlepper
  0 siblings, 0 replies; 5+ messages in thread
From: Felix Schlepper @ 2022-06-23 20:27 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Felix Schlepper


v2:
  - replaced kmalloc with kzalloc against memory initialization defects,
    thus also removing a memset
  - made error handling more consistent

v3:
  - Split into smaller commits so that it's easier to review

v4:
  - clearer commit messages
  - added missing kfree

Felix Schlepper (3):
  Staging: rtl8192e: Use struct_size
  Staging: rtl8192e: Using kzalloc and delete memset
  Staging: rtl8192e: Cleaning up error handling

 drivers/staging/rtl8192e/rtllib_tx.c | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

--
2.36.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-06-23 20:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-23 10:05 [PATCH v4 0/3] Staging: rtl8192e: Safer allocation and cleaner error handling Felix Schlepper
2022-06-23 10:22 ` Dan Carpenter
2022-06-23 10:47 ` Greg KH
2022-06-23 13:38   ` Felix Schlepper
  -- strict thread matches above, loose matches on Subject: below --
2022-06-23 20:27 Felix Schlepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).