From: Petr Mladek <pmladek@suse.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
"Marco Elver" <elver@google.com>,
"David Laight" <David.Laight@ACULAB.COM>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Paul E . McKenney" <paulmck@kernel.org>,
"Zhouyi Zhou" <zhouzhouyi@gmail.com>,
dave@stgolabs.net, "Josh Triplett" <josh@joshtriplett.org>,
rcu@vger.kernel.org, frederic@kernel.org,
"Marek Behún" <kabel@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/6] printk: Revert console kthreads for 5.19
Date: Thu, 23 Jun 2022 16:51:51 +0200 [thread overview]
Message-ID: <20220623145157.21938-1-pmladek@suse.com> (raw)
We have had several discussions with the other printk developers and
together decided that we would like more time to investigate
the implicit expectations [1] of each and every console driver
because now we are concerned that there may be more hidden implicit
expectations.
We much appreciate the chance to have this in 5.19 release candidates
because the wider user base helped us to get feedback from user cases
and architectures that we were not able to cover. And we see that
the patchset needs some more love.
We are sorry for the inconvenience and thanks a lot for the feedback
and help with debugging and testing.
This patchset reverts only the final patches adding the kthreads and
per-console. It keeps the refactoring of the console_unlock() code
that makes sense on its own.
[1] https://lore.kernel.org/all/YrBdjVwBOVgLfHyb@alley/
PS: I am going to prepare a proper pull request. I just wanted
to send this in advance just in case anyone wants to comment
on it.
Petr Mladek (6):
Revert "printk: Wait for the global console lock when the system is
going down"
Revert "printk: Block console kthreads when direct printing will be
required"
Revert "printk: remove @console_locked"
Revert "printk: extend console_lock for per-console locking"
Revert "printk: add kthread console printers"
Revert "printk: add functions to prefer direct printing"
drivers/tty/sysrq.c | 2 -
include/linux/console.h | 17 --
include/linux/printk.h | 16 -
kernel/hung_task.c | 11 +-
kernel/panic.c | 6 -
kernel/printk/internal.h | 2 -
kernel/printk/printk.c | 593 ++++--------------------------------
kernel/printk/printk_safe.c | 32 --
kernel/rcu/tree_stall.h | 2 -
kernel/reboot.c | 16 +-
kernel/watchdog.c | 4 -
kernel/watchdog_hld.c | 4 -
12 files changed, 65 insertions(+), 640 deletions(-)
--
2.35.3
next reply other threads:[~2022-06-23 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 14:51 Petr Mladek [this message]
2022-06-23 14:51 ` [PATCH 1/6] Revert "printk: Wait for the global console lock when the system is going down" Petr Mladek
2022-06-23 14:51 ` [PATCH 2/6] Revert "printk: Block console kthreads when direct printing will be required" Petr Mladek
2022-06-23 14:51 ` [PATCH 3/6] Revert "printk: remove @console_locked" Petr Mladek
2022-06-23 14:51 ` [PATCH 4/6] Revert "printk: extend console_lock for per-console locking" Petr Mladek
2022-06-23 14:51 ` [PATCH 5/6] Revert "printk: add kthread console printers" Petr Mladek
2022-06-23 14:51 ` [PATCH 6/6] Revert "printk: add functions to prefer direct printing" Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623145157.21938-1-pmladek@suse.com \
--to=pmladek@suse.com \
--cc=David.Laight@ACULAB.COM \
--cc=Jason@zx2c4.com \
--cc=andy.shevchenko@gmail.com \
--cc=dave@stgolabs.net \
--cc=elver@google.com \
--cc=frederic@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=john.ogness@linutronix.de \
--cc=josh@joshtriplett.org \
--cc=kabel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=torvalds@linux-foundation.org \
--cc=zhouzhouyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox