From: Stephen Boyd <sboyd@kernel.org>
To: Jiri Slaby <jslaby@suse.cz>, mturquette@baylibre.com
Cc: mliska@suse.cz, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH 2/2] clk: renesas: rcar-gen4: Fix initconst confusion for cpg_pll_config
Date: Thu, 23 Jun 2022 17:42:39 -0700 [thread overview]
Message-ID: <20220624004240.DBCD4C3411D@smtp.kernel.org> (raw)
In-Reply-To: <20220623083217.26433-2-jslaby@suse.cz>
Quoting Jiri Slaby (2022-06-23 01:32:17)
> From: Andi Kleen <ak@linux.intel.com>
>
> A variable pointing to const isn't const itself. It'd have to contain
> "const" keyword after "*" too. Therefore, cpg_pll_config cannot be put
> to "rodata". Hence use __initdata instead of __initconst to fix this.
>
> [js] more explanatory commit message.
>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-renesas-soc@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
next prev parent reply other threads:[~2022-06-24 0:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 8:32 [PATCH 1/2] clk: pistachio: Fix initconst confusion Jiri Slaby
2022-06-23 8:32 ` [PATCH 2/2] clk: renesas: rcar-gen4: Fix initconst confusion for cpg_pll_config Jiri Slaby
2022-06-24 0:42 ` Stephen Boyd [this message]
2022-06-28 10:03 ` Geert Uytterhoeven
2022-06-24 0:42 ` [PATCH 1/2] clk: pistachio: Fix initconst confusion Stephen Boyd
2022-06-27 7:46 ` Jiri Slaby
2022-06-29 8:21 ` Stephen Boyd
2022-07-08 7:16 ` Jiri Slaby
2022-07-11 20:53 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624004240.DBCD4C3411D@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=ak@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=jslaby@suse.cz \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mliska@suse.cz \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox