RE: [PATCH 1/3] iommu: Add Visconti5 IOMMU driver

nobuhiro1.iwamatsu
2022-06-20T02:16:56Z

Hi,

> -----Original Message-----
> From: Baolu Lu <baolu.lu@linux.intel.com>
> Sent: Wednesday, May 25, 2022 3:27 PM
> To: iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; Joerg Roedel <joro@8bytes.org>; Will
> Deacon <will@kernel.org>; Rob Herring <robh+dt@kernel.org>; Jason
> Gunthorpe <jgg@nvidia.com>
> Cc: baolu.lu@linux.intel.com; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; iommu@lists.linux-foundation.org; ishikawa
> yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa@toshiba.co.jp>; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 1/3] iommu: Add Visconti5 IOMMU driver
>
> On 2022/5/25 09:31, Nobuhiro Iwamatsu wrote:
> > +static const struct iommu_ops visconti_atu_ops = {
> > + .domain_alloc = visconti_atu_domain_alloc,
> > + .probe_device = visconti_atu_probe_device,
> > + .release_device = visconti_atu_release_device,
> > + .device_group = generic_device_group,
> > + .of_xlate = visconti_atu_of_xlate,
> > + .pgsize_bitmap = ATU_IOMMU_PGSIZE_BITMAP,
> > + .default_domain_ops = &(const struct iommu_domain_ops) {
> > + .attach_dev = visconti_atu_attach_device,
> > + .detach_dev = visconti_atu_detach_device,
>
> The detach_dev callback is about to be deprecated. The new drivers should
> implement the default domain and blocking domain instead.

I see. I will update this with next version.

>
> > + .map = visconti_atu_map,
> > + .unmap = visconti_atu_unmap,
> > + .iova_to_phys = visconti_atu_iova_to_phys,
> > + .free = visconti_atu_domain_free,
> > + }
> > +};
>
> Best regards,
> baolu

Best regards,
Nobuhiro