public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	Rob Clark <robdclark@chromium.org>,
	Rob Clark <robdclark@gmail.com>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 01/15] drm/msm: Switch to pfn mappings
Date: Sat, 25 Jun 2022 15:54:36 -0700	[thread overview]
Message-ID: <20220625225454.81039-2-robdclark@gmail.com> (raw)
In-Reply-To: <20220625225454.81039-1-robdclark@gmail.com>

From: Rob Clark <robdclark@chromium.org>

I'm not entirely sure why we were using VM_MIXEDMAP.  These are never
CoW mappings.  Let's switch to be more consistent with what other
drivers and the GEM shmem helpers do.

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
 drivers/gpu/drm/msm/msm_gem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index ad7da2ca35ab..8ddbd2e001d4 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -259,7 +259,8 @@ static vm_fault_t msm_gem_fault(struct vm_fault *vmf)
 	VERB("Inserting %p pfn %lx, pa %lx", (void *)vmf->address,
 			pfn, pfn << PAGE_SHIFT);
 
-	ret = vmf_insert_mixed(vma, vmf->address, __pfn_to_pfn_t(pfn, PFN_DEV));
+	ret = vmf_insert_pfn(vma, vmf->address, pfn);
+
 out_unlock:
 	msm_gem_unlock(obj);
 out:
@@ -1051,7 +1052,7 @@ static int msm_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struct
 {
 	struct msm_gem_object *msm_obj = to_msm_bo(obj);
 
-	vma->vm_flags |= VM_IO | VM_MIXEDMAP | VM_DONTEXPAND | VM_DONTDUMP;
+	vma->vm_flags |= VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP;
 	vma->vm_page_prot = msm_gem_pgprot(msm_obj, vm_get_page_prot(vma->vm_flags));
 
 	return 0;
-- 
2.36.1


  reply	other threads:[~2022-06-25 22:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-25 22:54 [PATCH 00/15] drm+msm: Shrinker and LRU rework Rob Clark
2022-06-25 22:54 ` Rob Clark [this message]
2022-06-25 22:54 ` [PATCH 02/15] drm/msm: Make enable_eviction flag static Rob Clark
2022-06-25 22:54 ` [PATCH 03/15] drm/msm: Reorder lock vs submit alloc Rob Clark
2022-06-25 22:54 ` [PATCH 04/15] drm/msm: Small submit cleanup Rob Clark
2022-06-25 22:54 ` [PATCH 05/15] drm/msm: Split out idr_lock Rob Clark
2022-06-25 22:54 ` [PATCH 06/15] drm/msm/gem: Check for active in shrinker path Rob Clark
2022-06-25 22:54 ` [PATCH 07/15] drm/msm/gem: Rename update_inactive Rob Clark
2022-06-25 22:54 ` [PATCH 08/15] drm/msm/gem: Rename to pin/unpin_pages Rob Clark
2022-06-25 22:54 ` [PATCH 09/15] drm/msm/gem: Consolidate pin/unpin paths Rob Clark
2022-06-25 22:54 ` [PATCH 10/15] drm/msm/gem: Remove active refcnt Rob Clark
2022-06-25 22:54 ` [PATCH 11/15] drm/gem: Add LRU/shrinker helper Rob Clark
2022-06-25 22:54 ` [PATCH 12/15] drm/msm/gem: Convert to using drm_gem_lru Rob Clark
2022-06-25 22:54 ` [PATCH 13/15] drm/msm/gem: Unpin buffers earlier Rob Clark
2022-06-25 22:54 ` [PATCH 14/15] drm/msm/gem: Consolidate shrinker trace Rob Clark
2022-06-25 22:54 ` [PATCH 15/15] drm/msm/gem: Evict active GEM objects when necessary Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220625225454.81039-2-robdclark@gmail.com \
    --to=robdclark@gmail.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@chromium.org \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox