From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Jeff Xie <xiehuan09@gmail.com>
Cc: rostedt@goodmis.org, mingo@redhat.com, mhiramat@kernel.org,
zanussi@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 2/4] trace/objtrace: Get the value of the object
Date: Sun, 26 Jun 2022 00:58:24 +0900 [thread overview]
Message-ID: <20220626005824.cabbfe7d77baf3aa64ca7669@kernel.org> (raw)
In-Reply-To: <20220606160943.663180-3-xiehuan09@gmail.com>
Hi,
On Tue, 7 Jun 2022 00:09:41 +0800
Jeff Xie <xiehuan09@gmail.com> wrote:
> @@ -176,9 +275,27 @@ trace_object_trigger(struct event_trigger_data *data,
>
> field = obj_data->field;
> memcpy(&obj, rec + field->offset, sizeof(obj));
> - set_trace_object(obj, tr);
> + /* set the offset from the special object and the type size of the value*/
> + set_trace_object(obj, obj_data->obj_offset,
> + obj_data->obj_value_type_size, tr);
> }
>
> +static const struct objtrace_fetch_type objtrace_fetch_types[] = {
> + {"u8", 1},
> + {"s8", 1},
> + {"x8", 1},
> + {"u16", 2},
> + {"s16", 2},
> + {"x16", 2},
> + {"u32", 4},
> + {"s32", 4},
> + {"x32", 4},
> + {"u64", 8},
> + {"s64", 8},
> + {"x64", 8},
> + {NULL, 0},
> +};
As I said before, please use only 'uX' types at this moment,
since the objtrace event doesn't show the value with sign.
This means it only supports 'uX'.
Thank you,
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2022-06-25 15:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 16:09 [PATCH v12 0/4] trace: Introduce objtrace trigger to trace the kernel object Jeff Xie
2022-06-06 16:09 ` [PATCH v12 1/4] trace: Add trace any " Jeff Xie
2022-06-25 15:59 ` Masami Hiramatsu
2022-06-25 17:10 ` Jeff Xie
2022-06-06 16:09 ` [PATCH v12 2/4] trace/objtrace: Get the value of the object Jeff Xie
2022-06-25 15:58 ` Masami Hiramatsu [this message]
2022-06-25 17:01 ` Jeff Xie
2022-06-06 16:09 ` [PATCH v12 3/4] trace/objtrace: Add testcases for objtrace Jeff Xie
2022-06-25 16:03 ` Masami Hiramatsu
2022-06-25 17:05 ` Jeff Xie
2022-06-27 20:00 ` Shuah Khan
2022-06-06 16:09 ` [PATCH v12 4/4] trace/objtrace: Add documentation " Jeff Xie
2022-06-25 16:10 ` Masami Hiramatsu
2022-06-25 17:07 ` Jeff Xie
2022-06-21 1:55 ` [PATCH v12 0/4] trace: Introduce objtrace trigger to trace the kernel object Jeff Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220626005824.cabbfe7d77baf3aa64ca7669@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=xiehuan09@gmail.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox